Re: [PATCH v4 3/3] tracing: Histogram for missed timer offsets

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 3/3] tracing: Histogram for missed timer offsets
Date	2016-08-31 14:50 +0200
Message-ID	<scd7P-2sm-11@gated-at.bofh.it> (permalink)
References	<sbOsN-3yX-13@gated-at.bofh.it> <sbOsO-3yX-37@gated-at.bofh.it> <sbS3n-5Yg-5@gated-at.bofh.it> <scc26-1Ql-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 31 Aug 2016 17:04:54 +0530
Binoy Jayan <binoy.jayan@linaro.org> wrote:

> On 30 August 2016 at 19:45, Steven Rostedt <rostedt@goodmis.org> wrote:
> > On Tue, 30 Aug 2016 15:58:44 +0530
> > Binoy Jayan <binoy.jayan@linaro.org> wrote:
> >  
> >> +
> >> +     TP_STRUCT__entry(
> >> +             __field(long long,      toffset)
> >> +             __array(char,           ccomm,  TASK_COMM_LEN)  
> >
> > Can curr be different than current? If not, lets not record it.
> >
> > -- Steve
> >  
> 
> Hi Steve,
> 
> If my understanding is right, I think both are not the same. The
> predefined field relates to the current
> process which was interrupted by the hrtimer. This I guess does not
> have a meaning in this context.
> Mostly it is the idle process which is interrupted by the hrtimer. But
> the ccomm field refers to the task
> woken up by the process. The latencies are measured for this task. So
> I it is needed.
> 

Then what is tcomm?

-- Steve

Thread

[PATCH v4 0/3] *** Latency histograms - IRQSOFF,PREEMPTOFF *** Binoy Jayan <binoy.jayan@linaro.org> - 2016-08-30 12:30 +0200
  [PATCH v4 1/3] tracing: Deference pointers without RCU checks Binoy Jayan <binoy.jayan@linaro.org> - 2016-08-30 12:30 +0200
  [PATCH v4 3/3] tracing: Histogram for missed timer offsets Binoy Jayan <binoy.jayan@linaro.org> - 2016-08-30 12:30 +0200
    Re: [PATCH v4 3/3] tracing: Histogram for missed timer offsets Masami Hiramatsu <masami.hiramatsu@linaro.org> - 2016-08-30 13:00 +0200
      Re: [PATCH v4 3/3] tracing: Histogram for missed timer offsets Binoy Jayan <binoy.jayan@linaro.org> - 2016-09-02 14:50 +0200
        Re: [PATCH v4 3/3] tracing: Histogram for missed timer offsets Masami Hiramatsu <masami.hiramatsu@linaro.org> - 2016-09-02 18:00 +0200
    Re: [PATCH v4 3/3] tracing: Histogram for missed timer offsets Steven Rostedt <rostedt@goodmis.org> - 2016-08-30 16:20 +0200
      Re: [PATCH v4 3/3] tracing: Histogram for missed timer offsets Binoy Jayan <binoy.jayan@linaro.org> - 2016-08-31 13:40 +0200
        Re: [PATCH v4 3/3] tracing: Histogram for missed timer offsets Steven Rostedt <rostedt@goodmis.org> - 2016-08-31 14:50 +0200
  Re: [PATCH v4 0/3] *** Latency histograms - IRQSOFF,PREEMPTOFF *** Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-08-30 13:50 +0200
    Re: [PATCH v4 0/3] *** Latency histograms - IRQSOFF,PREEMPTOFF *** Masami Hiramatsu <masami.hiramatsu@linaro.org> - 2016-08-30 14:10 +0200

csiph-web