Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1473383

Re: [PATCH] bfa: do not dereference port before it is null checked

Show all headers | View raw

On Tue, Aug 30, 2016 at 05:36:16PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> port is deferenced before it is null sanity checked, hence
> we potentially have a null pointer dereference bug. Instead,
> initialise trl_enabled from port->fcs->bfa after we are sure
> port is not null.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] bfa: do not dereference port before it is null checked Colin King <colin.king@canonical.com> - 2016-08-30 18:40 +0200
  Re: [PATCH] bfa: do not dereference port before it is null checked Johannes Thumshirn <jthumshirn@suse.de> - 2016-08-31 14:10 +0200
  Re: [PATCH] bfa: do not dereference port before it is null checked "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-09-02 12:20 +0200

csiph-web