Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1473368
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH V2 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers |
| Date | 2016-08-31 13:50 +0200 |
| Message-ID | <sccbM-1TJ-19@gated-at.bofh.it> (permalink) |
| References | <scc26-1Ql-3@gated-at.bofh.it> <scc26-1Ql-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wednesday, August 31, 2016 7:48:14 PM CEST Dongdong Liu wrote:
> +static struct hisi_rc_res rc_res[] = {
> + {
> + HIP05,
> + {
> + DEFINE_RES_MEM(0xb0070000, SZ_4K),
> + DEFINE_RES_MEM(0xb0080000, SZ_4K),
> + DEFINE_RES_MEM(0xb0090000, SZ_4K),
> + DEFINE_RES_MEM(0xb00a0000, SZ_4K)
> + }
> + },
> + {
> + HIP06,
> + {
> + DEFINE_RES_MEM(0xa0090000, SZ_4K),
> + DEFINE_RES_MEM(0xa0200000, SZ_4K),
> + DEFINE_RES_MEM(0xa00a0000, SZ_4K),
> + DEFINE_RES_MEM(0xa00b0000, SZ_4K)
> + }
> + },
> + {
> + HIP07,
> + {
> + DEFINE_RES_MEM(0xa0090000, SZ_4K),
> + DEFINE_RES_MEM(0xa0200000, SZ_4K),
> + DEFINE_RES_MEM(0xa00a0000, SZ_4K),
> + DEFINE_RES_MEM(0xa00b0000, SZ_4K),
> + DEFINE_RES_MEM(0x8a0090000UL, SZ_4K),
> + DEFINE_RES_MEM(0x8a0200000UL, SZ_4K),
> + DEFINE_RES_MEM(0x8a00a0000UL, SZ_4K),
> + DEFINE_RES_MEM(0x8a00b0000UL, SZ_4K),
> + DEFINE_RES_MEM(0x600a0090000UL, SZ_4K),
> + DEFINE_RES_MEM(0x600a0200000UL, SZ_4K),
> + DEFINE_RES_MEM(0x600a00a0000UL, SZ_4K),
> + DEFINE_RES_MEM(0x600a00b0000UL, SZ_4K),
> + DEFINE_RES_MEM(0x700a0090000UL, SZ_4K),
> + DEFINE_RES_MEM(0x700a0200000UL, SZ_4K),
> + DEFINE_RES_MEM(0x700a00a0000UL, SZ_4K),
> + DEFINE_RES_MEM(0x700a00b0000UL, SZ_4K)
> + }
> + },
I don't know much about ACPI, but I'm pretty sure this is not
the normal way to find MMIO resources. Why not read them from
the ACPI tables?
Arnd
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH V2 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers Dongdong Liu <liudongdong3@huawei.com> - 2016-08-31 13:40 +0200
Re: [RFC PATCH V2 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers Arnd Bergmann <arnd@arndb.de> - 2016-08-31 13:50 +0200
Re: [RFC PATCH V2 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers Dongdong Liu <liudongdong3@huawei.com> - 2016-09-01 04:20 +0200
Re: [RFC PATCH V2 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-09-01 01:00 +0200
Re: [RFC PATCH V2 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers Dongdong Liu <liudongdong3@huawei.com> - 2016-09-01 05:30 +0200
Re: [RFC PATCH V2 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-09-02 01:40 +0200
Re: [RFC PATCH V2 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers Dongdong Liu <liudongdong3@huawei.com> - 2016-09-02 06:00 +0200
csiph-web