[PATCH] pinctrl: intel: merrifield: fix dup size in probe

From	Vincent Stehlé <vincent.stehle@intel.com>
Newsgroups	linux.kernel
Subject	[PATCH] pinctrl: intel: merrifield: fix dup size in probe
Date	2016-08-31 14:40 +0200
Message-ID	<sccYa-2pg-11@gated-at.bofh.it> (permalink)
References	<sccYa-2pg-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

In function mrfld_pinctrl_probe(), when duplicating the mrfld_families
array the requested memory region length is multiplied once too many by the
number of elements in the original array. Fix this to spare some memory.

Fixes: 4e80c8f505741cbd ("pinctrl: intel: Add Intel Merrifield pin controller support")
Signed-off-by: Vincent Stehlé <vincent.stehle@intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/pinctrl/intel/pinctrl-merrifield.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/intel/pinctrl-merrifield.c b/drivers/pinctrl/intel/pinctrl-merrifield.c
index 7fb7656..7826c7f 100644
--- a/drivers/pinctrl/intel/pinctrl-merrifield.c
+++ b/drivers/pinctrl/intel/pinctrl-merrifield.c
@@ -854,7 +854,7 @@ static int mrfld_pinctrl_probe(struct platform_device *pdev)
 	 */
 	nfamilies = ARRAY_SIZE(mrfld_families),
 	families = devm_kmemdup(&pdev->dev, mrfld_families,
-					    nfamilies * sizeof(mrfld_families),
+					    sizeof(mrfld_families),
 					    GFP_KERNEL);
 	if (!families)
 		return -ENOMEM;
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: intel: merrifield: fix dup size in probe Vincent Stehlé <vincent.stehle@intel.com> - 2016-08-31 14:40 +0200
  Re: [PATCH] pinctrl: intel: merrifield: fix dup size in probe Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-08-31 16:00 +0200
  Re: [PATCH] pinctrl: intel: merrifield: fix dup size in probe Linus Walleij <linus.walleij@linaro.org> - 2016-09-07 22:10 +0200

csiph-web