Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1473253
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] phy: add missing header dependencies |
| Date | 2016-08-31 12:30 +0200 |
| Message-ID | <scaWm-1dE-3@gated-at.bofh.it> (permalink) |
| References | <sc9xf-cp-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wednesday, August 31, 2016 4:56:49 PM CEST Baoyou Xie wrote: > We get 5 warnings when building kernel with W=1: > drivers/phy/tegra/xusb.c:948:27: warning: no previous prototype for 'tegra_xusb_padctl_get' [-Wmissing-prototypes] > drivers/phy/tegra/xusb.c:981:6: warning: no previous prototype for 'tegra_xusb_padctl_put' [-Wmissing-prototypes] > drivers/phy/tegra/xusb.c:988:5: warning: no previous prototype for 'tegra_xusb_padctl_usb3_save_context' [-Wmissing-prototypes] > drivers/phy/tegra/xusb.c:998:5: warning: no previous prototype for 'tegra_xusb_padctl_hsic_set_idle' [-Wmissing-prototypes] > drivers/phy/tegra/xusb.c:1008:5: warning: no previous prototype for 'tegra_xusb_padctl_usb3_set_lfps_detect' [-Wmissing-prototypes] > > In fact, these functions are declared in linux/phy/tegra/xusb.h, > so this patch adds missing header dependencies. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> Patch looks good Acked-by: Arnd Bergmann <arnd@arndb.de> In the subject line, this time being more specific is better (there are many distinct phy drivers), so use "phy: tegra: ..." here. Arnd
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] phy: add missing header dependencies Baoyou Xie <baoyou.xie@linaro.org> - 2016-08-31 11:00 +0200 Re: [PATCH] phy: add missing header dependencies Arnd Bergmann <arnd@arndb.de> - 2016-08-31 12:30 +0200 Re: [PATCH] phy: add missing header dependencies Thierry Reding <thierry.reding@gmail.com> - 2016-09-01 13:40 +0200
csiph-web