[PATCH v2 06/15] Add comment about why 32-bit read/modify/write isn't safe.

From	Bjorn Helgaas <bhelgaas@google.com>
Newsgroups	linux.kernel
Subject	[PATCH v2 06/15] Add comment about why 32-bit read/modify/write isn't safe.
Date	2016-09-02 18:00 +0200
Message-ID	<scZ2P-1kr-27@gated-at.bofh.it> (permalink)
References	<scZ2O-1kr-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

---
 drivers/pci/host/pcie-rockchip.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
index ea75f35..c0c3ad5 100644
--- a/drivers/pci/host/pcie-rockchip.c
+++ b/drivers/pci/host/pcie-rockchip.c
@@ -282,6 +282,11 @@ static int rockchip_pcie_wr_own_conf(struct rockchip_pcie *rockchip,
 
 	mask = ~(((1 << (size * 8)) - 1) << ((where & 0x3) * 8));
 
+	/*
+	 * N.B. This read/modify/write isn't safe in general because it can
+	 * corrupt RW1C bits in adjacent registers.  But the hardware
+	 * doesn't support smaller writes.
+	 */
 	tmp = readl(rockchip->apb_base + PCIE_RC_CONFIG_BASE + offset) & mask;
 	tmp |= val << ((where & 0x3) * 8);
 	writel(tmp, rockchip->apb_base + PCIE_RC_CONFIG_BASE + offset);

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v2 06/15] Add comment about why 32-bit read/modify/write  isn't safe. Bjorn Helgaas <bhelgaas@google.com> - 2016-09-02 18:00 +0200

csiph-web