Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1475231

Re: [PATCH v3 1/2] regulator: pwm: Add support for a fixed delay after duty cycle changes

Show all headers | View raw

On Fri, Sep 02, 2016 at 10:11:51AM -0500, Rob Herring wrote:
> On Tue, Aug 30, 2016 at 09:21:15PM -0700, Douglas Anderson wrote:
> > From: Matthias Kaehlcke <mka@chromium.org>
> > 
> > A change of the duty cycle doesn't necessarily cause an immediate switch
> > to the target voltage.  On many PWM regulators there is a fixed "settle
> > time" (irrespective of the jump size) that we need to wait after an
> > upward jump.  This change introduces the device tree property
> > "settle-time-up-us" which allows us to specify a fixed delay after a
> > voltage increase.
> > 
> > We don't add an option of a fixed delay on the way down for now because
> > the way down is probably modelled best with a ramp rate, not a fixed
> > delay.
> > 
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > ---
> > Changes in v3:
> > - Took out fixed delay for falling transitions
> > - Updated description
> > 
> >  .../devicetree/bindings/regulator/pwm-regulator.txt   |  6 ++++++
> 
> Acked-by: Rob Herring <robh@kernel.org>

I take that back. What Mark said...

> 
> >  drivers/regulator/pwm-regulator.c                     | 19 +++++++++++++++----
> >  2 files changed, 21 insertions(+), 4 deletions(-)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/2] regulator: pwm: Add support for a fixed delay after duty cycle changes Douglas Anderson <dianders@chromium.org> - 2016-08-31 06:30 +0200
  [PATCH v3 2/2] regulator: pwm: Prevent falling too fast Douglas Anderson <dianders@chromium.org> - 2016-08-31 06:30 +0200
    Re: [PATCH v3 2/2] regulator: pwm: Prevent falling too fast Mark Brown <broonie@kernel.org> - 2016-09-01 23:10 +0200
  Re: [PATCH v3 1/2] regulator: pwm: Add support for a fixed delay  after duty cycle changes Mark Brown <broonie@kernel.org> - 2016-09-01 23:10 +0200
  Re: [PATCH v3 1/2] regulator: pwm: Add support for a fixed delay  after duty cycle changes Rob Herring <robh@kernel.org> - 2016-09-02 17:20 +0200
  Re: [PATCH v3 1/2] regulator: pwm: Add support for a fixed delay  after duty cycle changes Rob Herring <robh@kernel.org> - 2016-09-02 17:20 +0200

csiph-web