Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1475160

Re: [Question] about patch: don't use [delayed_]work_pending()

Show all headers | View raw

Hello,

On Fri, Sep 02, 2016 at 09:17:04AM +0800, qiaozhou wrote:
> > > I don't know whether it's meaningful to still check pending work here, or
> > > it's not suggested to use pm_qos_update_request in this early boot up phase.
> > > Could you help to share some opinions? (I can fix this issue by adding the
> > > current qos value directly instead of default value, though.)
> > Hmmm... but I suppose this is super-early in the boot.  Would it make
> > sense to have a static variable (e.g. bool clk_fully_initailized) to
> > gate the cancel_delayed_sync() call?
>
> You're right that it's indeed super-early stage. But currently we can't
> control the gate of can_delayed_work_sync, since it's inside
> pm_qos_update_request. Out of our control. We can choose to not call
> pm_qos_update_request to avoid this issue, and use pm_qos_add_request
> alternatively. Good to have it.

Ah sorry, didn't understand that the offending cancel_sync call is in
the generic part.  Hmm... but yeah, we should still be able to take
the same approach.  I'll see what's the right thing to gate the
operation there.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[Question] about patch: don't use [delayed_]work_pending() qiaozhou <qiaozhou@asrmicro.com> - 2016-09-01 11:30 +0200
  Re: [Question] about patch: don't use [delayed_]work_pending() Tejun Heo <tj@kernel.org> - 2016-09-01 23:40 +0200
    Re: [Question] about patch: don't use [delayed_]work_pending() qiaozhou <qiaozhou@asrmicro.com> - 2016-09-02 03:20 +0200
      Re: [Question] about patch: don't use [delayed_]work_pending() Tejun Heo <tj@kernel.org> - 2016-09-02 16:00 +0200
        Re: [Question] about patch: don't use [delayed_]work_pending() Tejun Heo <tj@kernel.org> - 2016-09-02 16:30 +0200
          Re: [Question] about patch: don't use [delayed_]work_pending() qiaozhou <qiaozhou@asrmicro.com> - 2016-09-03 17:30 +0200
          Re: [Question] about patch: don't use [delayed_]work_pending() qiaozhou <qiaozhou@asrmicro.com> - 2016-09-05 07:40 +0200
            [PATCH] power: avoid calling cancel_delayed_work_sync() during early  boot Tejun Heo <tj@kernel.org> - 2016-09-05 14:40 +0200
              Re: [PATCH] power: avoid calling cancel_delayed_work_sync() during  early boot "Rafael J. Wysocki" <rafael@kernel.org> - 2016-09-05 15:00 +0200

csiph-web