Re: [PATCH 1/4] KVM: x86: always fill in vcpu->arch.hv_clock

From	Paolo Bonzini <pbonzini@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/4] KVM: x86: always fill in vcpu->arch.hv_clock
Date	2016-09-02 15:50 +0200
Message-ID	<scX0Z-67-5@gated-at.bofh.it> (permalink)
References	<scC6e-3Bv-17@gated-at.bofh.it> <scC6f-3Bv-37@gated-at.bofh.it> <scX0Z-67-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 02/09/2016 15:31, Roman Kagan wrote:
> >  
> > -	if (!vcpu->pv_time_enabled)
> > -		return 0;
> 
> Strictly speaking, you only need .hv_clock updated if either kvmclock or
> tsc_ref_page is enabled, so you may want to still skip the calculations
> otherwise.

Yeah, but that's really a rare case so I don't think it's worth it...

Paolo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] KVM: x86: kvmclock cleanups for Hyper-V TSC page Paolo Bonzini <pbonzini@redhat.com> - 2016-09-01 17:30 +0200
  [PATCH 4/4] KVM: x86: Hyper-V tsc page setup Paolo Bonzini <pbonzini@redhat.com> - 2016-09-01 17:30 +0200
  [PATCH 1/4] KVM: x86: always fill in vcpu->arch.hv_clock Paolo Bonzini <pbonzini@redhat.com> - 2016-09-01 17:30 +0200
    Re: [PATCH 1/4] KVM: x86: always fill in vcpu->arch.hv_clock Paolo Bonzini <pbonzini@redhat.com> - 2016-09-02 15:50 +0200

csiph-web