[PATCH] crypto: ccp - add missing release in ccp_dmaengine_register

From	Quentin Lambert <lambert.quentin@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] crypto: ccp - add missing release in ccp_dmaengine_register
Date	2016-09-02 12:00 +0200
Message-ID	<scTqq-6ej-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

ccp_dmaengine_register used to return with an error code before
releasing all resource. This patch adds a jump to the appropriate label
ensuring that the resources are properly released before returning.

This issue was found with Hector.

Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
---
 drivers/crypto/ccp/ccp-dmaengine.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

--- a/drivers/crypto/ccp/ccp-dmaengine.c
+++ b/drivers/crypto/ccp/ccp-dmaengine.c
@@ -650,8 +650,11 @@ int ccp_dmaengine_register(struct ccp_de
 	dma_desc_cache_name = devm_kasprintf(ccp->dev, GFP_KERNEL,
 					     "%s-dmaengine-desc-cache",
 					     ccp->name);
-	if (!dma_cmd_cache_name)
-		return -ENOMEM;
+	if (!dma_cmd_cache_name) {
+		ret = -ENOMEM;
+		goto err_cache;
+	}
+
 	ccp->dma_desc_cache = kmem_cache_create(dma_desc_cache_name,
 						sizeof(struct ccp_dma_desc),
 						sizeof(void *),

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] crypto: ccp - add missing release in ccp_dmaengine_register  Quentin Lambert <lambert.quentin@gmail.com> - 2016-09-02 12:00 +0200
  Re: [PATCH] crypto: ccp - add missing release in  ccp_dmaengine_register Herbert Xu <herbert@gondor.apana.org.au> - 2016-09-07 15:30 +0200

csiph-web