Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1474721

Re: [PATCH] staging: ks7010: fix coding style issues in ks7010_sdio.c

Show all headers | View raw

On Thu, Sep 01, 2016 at 11:18:15PM +0530, Sabitha George wrote:
> This is a patch to the ks7010_sdio.c that fixes the following
> warnings found by checkpatch.pl
> 1) Missing a blank line after declarations
> 2) braces are not necessary for single statement blocks
> 3) kfree(NULL) is safe and this check is probably not required
> 4) void function return statements are not generally useful
> 5) "foo * bar" should be "foo *bar"
> 6) Code indent should use tabs where possible
> 7) printk() should include KERN_ facility level

That's 7 different things, so this should be at least 7 different
patches :)

Please break this up and submit it as a patch series so it can be easily
reviewed and applied.

thanks,

greg k-h

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] staging: ks7010: fix coding style issues in ks7010_sdio.c Greg KH <gregkh@linuxfoundation.org> - 2016-09-02 00:00 +0200

csiph-web