Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1474602

[PATCH] ptrace: clear TIF_SYSCALL_TRACE on ptrace detach

Show all headers | View raw

On __ptrace_detach(), called from do_exit()->exit_notify()->
forget_original_parent()->exit_ptrace(), the TIF_SYSCALL_TRACE in
thread->flags of the tracee is not cleared up. This results in the
tracehook_report_syscall_* being called (though there's no longer a
tracer listening to that) upon its further syscalls.

Example scenario - attach "strace" to a running process and kill it (the
strace) with SIGKILL. You'll see that the syscall trace hooks are still
being called.

The clearing of this flag should be moved from ptrace_detach() to
__ptrace_detach().

Signed-off-by: Ales Novak <alnovak@suse.cz>
Cc: Jiri Kosina <jkosina@suse.cz>
---
 kernel/ptrace.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/ptrace.c b/kernel/ptrace.c
index 1d3b766..2a99027 100644
--- a/kernel/ptrace.c
+++ b/kernel/ptrace.c
@@ -73,6 +73,8 @@ void __ptrace_unlink(struct task_struct *child)
 {
 	BUG_ON(!child->ptrace);
 
+	clear_tsk_thread_flag(child, TIF_SYSCALL_TRACE);
+
 	child->parent = child->real_parent;
 	list_del_init(&child->ptrace_entry);
 
@@ -489,7 +491,6 @@ static int ptrace_detach(struct task_struct *child, unsigned int data)
 
 	/* Architecture-specific hardware disable .. */
 	ptrace_disable(child);
-	clear_tsk_thread_flag(child, TIF_SYSCALL_TRACE);
 
 	write_lock_irq(&tasklist_lock);
 	/*
-- 
2.7.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ptrace: clear TIF_SYSCALL_TRACE on ptrace detach Ales Novak <alnovak@suse.cz> - 2016-09-01 16:00 +0200
  Re: [PATCH] ptrace: clear TIF_SYSCALL_TRACE on ptrace detach Oleg Nesterov <oleg@redhat.com> - 2016-09-01 18:50 +0200
    Re: [PATCH] ptrace: clear TIF_SYSCALL_TRACE on ptrace detach Ales Novak <alnovak@suse.cz> - 2016-09-01 23:10 +0200
    [PATCH] ptrace: clear TIF_SYSCALL_TRACE on ptrace detach Ales Novak <alnovak@suse.cz> - 2016-09-01 23:10 +0200
      Re: [PATCH] ptrace: clear TIF_SYSCALL_TRACE on ptrace detach Oleg Nesterov <oleg@redhat.com> - 2016-09-02 14:30 +0200

csiph-web