Re: [PATCH v5 5/8] char: rpmb: add RPMB simulation device

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 5/8] char: rpmb: add RPMB simulation device
Date	2016-09-01 23:10 +0200
Message-ID	<scHpg-70l-49@gated-at.bofh.it> (permalink)
References	<rWnkS-2Af-19@gated-at.bofh.it> <rWnuy-2E0-9@gated-at.bofh.it> <scbpo-1nW-11@gated-at.bofh.it> <scHpg-70l-51@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Sep 01, 2016 at 08:25:28PM +0000, Winkler, Tomas wrote:
> > On Mon, Jul 18, 2016 at 11:27:50PM +0300, Tomas Winkler wrote:
> > > This is a simple platform device used for testing the RPMB subsystem.
> > > +static struct platform_device *rpmb_sim_pdev;
> > 
> > A platform device?  Ick, no please don't abuse that interface for this type of
> > thing.  Make it a real device if you have one, and put it in the proper place.  If
> > it's a "virtual" device, great, use that.  But don't make something up like this
> > please.
> 
> This is a virtual device (simulation), nothing behind it just a chunk of memory.
> Is this there any information missing to make it clearer? 

Don't make it a platform device, make it a "virtual" device, don't abuse
the platform device/driver interface for something that isn't really a
platform device.

thanks,

greg k-h

Thread

Re: [PATCH v5 5/8] char: rpmb: add RPMB simulation device Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-31 13:00 +0200
  Re: [PATCH v5 5/8] char: rpmb: add RPMB simulation device Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-01 23:10 +0200
  RE: [PATCH v5 5/8] char: rpmb: add RPMB simulation device "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-09-01 23:20 +0200

csiph-web