Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1474565
| From | Eric Dumazet <eric.dumazet@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg |
| Date | 2016-09-01 18:50 +0200 |
| Message-ID | <scDlF-4lf-67@gated-at.bofh.it> (permalink) |
| References | <sa9i1-5Ly-3@gated-at.bofh.it> <sa9i2-5Ly-29@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, 2016-08-29 at 09:32 -0400, robert.foss@collabora.com wrote:
> From: Robert Foss <robert.foss@collabora.com>
>
> From: Grant Grundler <grundler@chromium.org>
>
> The miii_nway_restart() causes a PHY link change activity and
> ax88772_link_reset will be called. link_reset will set
> AX_CMD_WRITE_MEDIUM_MODE register correctly.
>
> The asix_write_medium_mode in reset() fills in a default value to the register
> which may be different from the negotiation result. So do this first.
>
> Ignore the ret value since it's ignored in XXX_link_reset() functions.
>
> Signed-off-by: Grant Grundler <grundler@google.com>
> Signed-off-by: Robert Foss <robert.foss@collabora.com>
> Tested-by: Robert Foss <robert.foss@collabora.com>
> ---
This is _really_ confusing Robert.
Why having two 'From:' clauses ?
Who wrote the patch in the first place ? You or Grant ?
End result is :
commit 535baf8588d04b177cb33700f81499f2b5203c2d
Author: Robert Foss <robert.foss@collabora.com>
Date: Mon Aug 29 09:32:19 2016 -0400
net: asix: autoneg will set WRITE_MEDIUM reg
From: Grant Grundler <grundler@chromium.org>
The miii_nway_restart() causes a PHY link change activity and
ax88772_link_reset will be called. link_reset will set
AX_CMD_WRITE_MEDIUM_MODE register correctly.
The asix_write_medium_mode in reset() fills in a default value to the register
which may be different from the negotiation result. So do this first.
Ignore the ret value since it's ignored in XXX_link_reset() functions.
Signed-off-by: Grant Grundler <grundler@google.com>
Signed-off-by: Robert Foss <robert.foss@collabora.com>
Tested-by: Robert Foss <robert.foss@collabora.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
I guess Grant wrote the patch, but attribution is wrong.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 0/5] net/usb: asix driver improvements robert.foss@collabora.com - 2016-08-25 22:20 +0200
[PATCH v3 4/5] net: asix: see 802.3 spec for phy reset robert.foss@collabora.com - 2016-08-25 22:20 +0200
[PATCH v3 4/5] net: asix: see 802.3 spec for phy reset robert.foss@collabora.com - 2016-08-25 22:20 +0200
[PATCH v3 3/5] net: asix: Fix AX88772x resume failures robert.foss@collabora.com - 2016-08-25 22:20 +0200
[PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg robert.foss@collabora.com - 2016-08-25 22:20 +0200
[PATCH v3 1/5] net: asix: Add in_pm parameter robert.foss@collabora.com - 2016-08-25 22:20 +0200
[PATCH v3 3/5] net: asix: Fix AX88772x resume failures robert.foss@collabora.com - 2016-08-25 22:20 +0200
[PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg robert.foss@collabora.com - 2016-08-25 22:20 +0200
Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg Robert Foss <robert.foss@collabora.com> - 2016-09-01 18:50 +0200
Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg Eric Dumazet <eric.dumazet@gmail.com> - 2016-09-01 23:10 +0200
Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg Grant Grundler <grundler@google.com> - 2016-09-06 18:50 +0200
Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg Robert Foss <robert.foss@collabora.com> - 2016-09-06 23:50 +0200
Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg Eric Dumazet <eric.dumazet@gmail.com> - 2016-09-01 18:50 +0200
[PATCH v3 2/5] net: asix: Avoid looping when the device is disconnected robert.foss@collabora.com - 2016-08-25 22:20 +0200
[PATCH v3 1/5] net: asix: Add in_pm parameter robert.foss@collabora.com - 2016-08-25 22:20 +0200
Re: [PATCH v3 0/5] net/usb: asix driver improvements David Miller <davem@davemloft.net> - 2016-08-27 06:30 +0200
[PATCH v3 3/5] net: asix: Fix AX88772x resume failures robert.foss@collabora.com - 2016-08-29 15:40 +0200
[PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg robert.foss@collabora.com - 2016-08-29 15:40 +0200
[PATCH v3 2/5] net: asix: Avoid looping when the device is disconnected robert.foss@collabora.com - 2016-08-29 15:40 +0200
[PATCH v3 1/5] net: asix: Add in_pm parameter robert.foss@collabora.com - 2016-08-29 15:40 +0200
[PATCH v3 4/5] net: asix: see 802.3 spec for phy reset robert.foss@collabora.com - 2016-08-29 15:40 +0200
Re: [PATCH v3 0/5] net/usb: asix driver improvements Robert Foss <robert.foss@collabora.com> - 2016-08-31 19:30 +0200
Re: [PATCH v3 0/5] net/usb: asix driver improvements David Miller <davem@davemloft.net> - 2016-09-01 06:10 +0200
csiph-web