Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1474545

Re: [PATCH] qed: fix kzalloc-simple.cocci warnings

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH] qed: fix kzalloc-simple.cocci warnings
Date 2016-09-01 18:50 +0200
Message-ID <scDlD-4lf-27@gated-at.bofh.it> (permalink)
References <sctZ0-5lz-15@gated-at.bofh.it> <sctZ0-5lz-13@gated-at.bofh.it> <scv4K-6oI-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Yuval Mintz <Yuval.Mintz@qlogic.com>
Date: Thu, 1 Sep 2016 07:37:13 +0000

>> drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1230:13-20: WARNING: kzalloc
>> should be used for dcbx_info, instead of kmalloc/memset
>> drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1192:13-20: WARNING: kzalloc
>> should be used for dcbx_info, instead of kmalloc/memset
>> 
>> 
>>  Use kzalloc rather than kmalloc followed by memset with 0
>> 
>>  This considers some simple cases that are common and easy to validate  Note in
>> particular that there are no ...s in the rule, so all of the  matched code has to be
>> contiguous
>> 
>> Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
>> 
>> CC: Sudarsana Reddy Kalluru <sudarsana.kalluru@qlogic.com>
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> 
> This looks fine; But what's the right process here -
> Dave - do we need to re-post this with the the right 'destination' in title
> [net/net-next]? Or is it good as-is?
> In case of latter,
> Acked-by: Yuval Mintz <Yuval.Mintz@qlogic.com>

I'll apply this as-is, thanks.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] qed: fix kzalloc-simple.cocci warnings kbuild test robot <fengguang.wu@intel.com> - 2016-09-01 08:50 +0200
  RE: [PATCH] qed: fix kzalloc-simple.cocci warnings Yuval Mintz <Yuval.Mintz@qlogic.com> - 2016-09-01 10:00 +0200
    Re: [PATCH] qed: fix kzalloc-simple.cocci warnings David Miller <davem@davemloft.net> - 2016-09-01 18:50 +0200
    Re: [PATCH] qed: fix kzalloc-simple.cocci warnings Joe Perches <joe@perches.com> - 2016-09-02 19:50 +0200
      [PATCH] qed: Remove OOM messages Joe Perches <joe@perches.com> - 2016-09-02 19:50 +0200
        RE: [PATCH] qed: Remove OOM messages Yuval Mintz <Yuval.Mintz@qlogic.com> - 2016-09-04 10:40 +0200
        Re: [PATCH] qed: Remove OOM messages David Miller <davem@davemloft.net> - 2016-09-04 22:40 +0200
          Re: [PATCH] qed: Remove OOM messages Joe Perches <joe@perches.com> - 2016-09-04 23:30 +0200

csiph-web