Re: [Patch v3 03/11] irqchip: axi-intc: Add support for parent intc

From	Marc Zyngier <marc.zyngier@arm.com>
Newsgroups	linux.kernel
Subject	Re: [Patch v3 03/11] irqchip: axi-intc: Add support for parent intc
Date	2016-09-01 16:50 +0200
Message-ID	<scBtw-398-3@gated-at.bofh.it> (permalink)
References	(1 earlier) <scgIq-4Kp-41@gated-at.bofh.it> <sch1M-4Rl-25@gated-at.bofh.it> <scy2C-11X-23@gated-at.bofh.it> <scz8l-1In-21@gated-at.bofh.it> <scAH7-2zZ-7@gated-at.bofh.it>
Organization	ARM Ltd

Show all headers | View raw

On 01/09/16 14:52, Zubair Lutfullah Kakakhel wrote:
> Hi,

[...]

>> But that still doesn't address the case I had in mind, which is when you
>> have *two* AXI-intc, one cascaded into the other. Is that something that
>> could be built? You should at least make sure that there is a big fat
>> warning if you don't want to support that case, because that will be
>> hell to debug.
> 
> Oo. I didn't think of that one. tbh, I'm not sure if that is currently supported
> because this driver came out of arch/microblaze. And it didn't have any code that
> looked supportive of chained interrupt handling.
> 
> 'Technically', it should be possible to synthesize two daisy chained axi interrupt
> controllers on an FPGA. But I don't see it being supported before.
> 
> A warning would be nice. Any suggestions on the most suitable way?

Check if you've already allocated a xintc_irqc. If so, abort the probing
early...

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[Patch v3 03/11] irqchip: axi-intc: Add support for parent intc Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> - 2016-08-31 18:40 +0200
  Re: [Patch v3 03/11] irqchip: axi-intc: Add support for parent intc Marc Zyngier <marc.zyngier@arm.com> - 2016-08-31 19:00 +0200
    Re: [Patch v3 03/11] irqchip: axi-intc: Add support for parent intc Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> - 2016-09-01 13:10 +0200
      Re: [Patch v3 03/11] irqchip: axi-intc: Add support for parent intc Marc Zyngier <marc.zyngier@arm.com> - 2016-09-01 14:20 +0200
        Re: [Patch v3 03/11] irqchip: axi-intc: Add support for parent intc Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> - 2016-09-01 16:00 +0200
          Re: [Patch v3 03/11] irqchip: axi-intc: Add support for parent intc Marc Zyngier <marc.zyngier@arm.com> - 2016-09-01 16:50 +0200

csiph-web