Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1474413

Re: [PATCH] USB: core: add missing header dependencies

Show all headers | View raw

On Thursday, September 1, 2016 9:33:59 PM CEST kbuild test robot wrote:
> Hi Baoyou,
> 
> [auto build test ERROR on arm-soc/for-next]
> [also build test ERROR on v4.8-rc4]
> [cannot apply to usb/usb-testing next-20160825]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> [Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
> [Check https://git-scm.com/docs/git-format-patch for more information]
> 

We already have a correct version of this patch in linux-next, see
below.

	Arnd


commit 0573f2c519e570d056989e57565e1ff1640dd794
Author: Peter Chen <peter.chen@nxp.com>
Date:   Wed Jun 15 11:25:43 2016 +0800

    usb: core: of.c: fix defined but not declare warning
    
    The helper usb_of_get_child_node is defined at of.c, but missing its
    declare as a global function. Fix it by adding related header file
    as well as compile it on conditional of CONFIG_OF.
    
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Arnd Bergmann <arnd@arndb.de>
    Cc: Alan Stern <stern@rowland.harvard.edu>
    Cc: linux-usb@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    Cc: Ben Dooks <ben.dooks@codethink.co.uk>
    Cc: linux-kernel@lists.codethink.co.uk
    
    Signed-off-by: Peter Chen <peter.chen@nxp.com>
    Reported-by: Ben Dooks <ben.dooks@codethink.co.uk>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/core/Makefile b/drivers/usb/core/Makefile
index 9780877010b4..da36b784a0ef 100644
--- a/drivers/usb/core/Makefile
+++ b/drivers/usb/core/Makefile
@@ -5,8 +5,9 @@
 usbcore-y := usb.o hub.o hcd.o urb.o message.o driver.o
 usbcore-y += config.o file.o buffer.o sysfs.o endpoint.o
 usbcore-y += devio.o notify.o generic.o quirks.o devices.o
-usbcore-y += port.o of.o
+usbcore-y += port.o
 
+usbcore-$(CONFIG_OF)		+= of.o
 usbcore-$(CONFIG_PCI)		+= hcd-pci.o
 usbcore-$(CONFIG_ACPI)		+= usb-acpi.o
 
diff --git a/drivers/usb/core/of.c b/drivers/usb/core/of.c
index 2289700c31d6..3de4f8873984 100644
--- a/drivers/usb/core/of.c
+++ b/drivers/usb/core/of.c
@@ -18,6 +18,7 @@
  */
 
 #include <linux/of.h>
+#include <linux/usb/of.h>
 
 /**
  * usb_of_get_child_node - Find the device node match port number

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] USB: core: add missing header dependencies Arnd Bergmann <arnd@arndb.de> - 2016-09-01 16:00 +0200

csiph-web