Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1473149

[PATCH 1/6] staging: slicoss: constify ethtool_ops structures

Show all headers | View raw

Check for ethtool_ops structures that are only stored in the ethtool_ops
field of a net_device structure or passed as the second argument to
netdev_set_default_ethtool_ops.  These contexts are declared const, so
ethtool_ops structures that have these properties can be declared as const
also.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct ethtool_ops i@p = { ... };

@ok1@
identifier r.i;
struct net_device e;
position p;
@@
e.ethtool_ops = &i@p;

@ok2@
identifier r.i;
expression e;
position p;
@@
netdev_set_default_ethtool_ops(e, &i@p)

@bad@
position p != {r.p,ok1.p,ok2.p};
identifier r.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct ethtool_ops i = { ... };
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 drivers/staging/slicoss/slicoss.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index 7834bda..21280a3 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -124,7 +124,7 @@ static const struct pci_device_id slic_pci_tbl[] = {
 	{ 0 }
 };
 
-static struct ethtool_ops slic_ethtool_ops;
+static const struct ethtool_ops slic_ethtool_ops;
 
 MODULE_DEVICE_TABLE(pci, slic_pci_tbl);
 
@@ -3128,7 +3128,7 @@ static void __exit slic_module_cleanup(void)
 	pci_unregister_driver(&slic_driver);
 }
 
-static struct ethtool_ops slic_ethtool_ops = {
+static const struct ethtool_ops slic_ethtool_ops = {
 	.get_coalesce = slic_get_coalesce,
 	.set_coalesce = slic_set_coalesce
 };

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] constify ethtool_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-08-31 09:50 +0200
  [PATCH 2/6] net: ethernet: et131x: constify ethtool_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-08-31 09:50 +0200
    Re: [PATCH 2/6] net: ethernet: et131x: constify ethtool_ops  structures Mark Einon <mark@einon.net> - 2016-08-31 13:50 +0200
  [PATCH 6/6] net: systemport: constify ethtool_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-08-31 09:50 +0200
    Re: [PATCH 6/6] net: systemport: constify ethtool_ops structures Florian Fainelli <f.fainelli@gmail.com> - 2016-08-31 19:10 +0200
  [PATCH 3/6] net: bcmgenet: constify ethtool_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-08-31 09:50 +0200
    Re: [PATCH 3/6] net: bcmgenet: constify ethtool_ops structures Florian Fainelli <f.fainelli@gmail.com> - 2016-08-31 19:10 +0200
  [PATCH 5/6] dwc_eth_qos: constify ethtool_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-08-31 10:00 +0200
  [PATCH 1/6] staging: slicoss: constify ethtool_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-08-31 10:00 +0200
  [PATCH 4/6] net: hisilicon: constify ethtool_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-08-31 10:00 +0200
  Re: [PATCH 0/6] constify ethtool_ops structures Stephen Hemminger <stephen@networkplumber.org> - 2016-08-31 17:40 +0200
    Re: [PATCH 0/6] constify ethtool_ops structures Julia Lawall <julia.lawall@lip6.fr> - 2016-08-31 21:50 +0200
  Re: [PATCH 0/6] constify ethtool_ops structures David Miller <davem@davemloft.net> - 2016-08-31 18:30 +0200

csiph-web