Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1471940

Re: [PATCH V6 0/5] perf: Driver specific configuration for PMU

From Mathieu Poirier <mathieu.poirier@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH V6 0/5] perf: Driver specific configuration for PMU
Date 2016-08-29 18:00 +0200
Message-ID <sbx8B-Ie-7@gated-at.bofh.it> (permalink)
References <sa9rH-5Q6-1@gated-at.bofh.it> <sb96i-2Nl-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 28 August 2016 at 08:18, Jiri Olsa <jolsa@redhat.com> wrote:
> On Thu, Aug 25, 2016 at 02:20:40PM -0600, Mathieu Poirier wrote:
>
> SNIP
>
>> perf record -e some_event/@cfg1,@cfg2=config/ ...
>>
>> The above are all valid configuration and will see the strings 'cfg1'
>> and 'cfg2=config' sent to the PMU driver for parsing and interpretation
>> using the existing ioctl() mechanism.
>>
>> The primary customers for this feature are the CoreSight drivers where
>> the selection of a sink (where trace data is accumulated) needs to be
>> done in a previous, and separated step, from the launching of the perf
>> command.
>>
>> As such something that used to be a two-step process:
>>
>> # echo 1 > /sys/bus/coresight/devices/20070000.etr/enable_sink
>> # perf record -e cs_etm//u --per-thread  uname
>>
>> is integrated in a single command:
>>
>> # perf record -e cs_etm/@20070000.etr/u --per-thread  uname
>>
>> Thanks,
>> Mathieu
>>
>> Changes for V6:
>> - Using sysFS rather than an ioctl() to communicate command line
>>   parameters to the CoreSight PMU.
>
> apart from few nits it looks good.. but can't say for patch 2/5 ;-)
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
>

Many thanks for taking the time to look at this set - your time is
much appreciated.

> thanks,
> jirka

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH V6 0/5] perf: Driver specific configuration for PMU  Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-08-25 22:30 +0200
  [PATCH V6 1/5] perf tools: making coresight PMU listable Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-08-25 22:30 +0200
    Re: [PATCH V6 1/5] perf tools: making coresight PMU listable Jiri Olsa <jolsa@redhat.com> - 2016-08-28 16:20 +0200
      Re: [PATCH V6 1/5] perf tools: making coresight PMU listable Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-08-29 18:00 +0200
        Re: [PATCH V6 1/5] perf tools: making coresight PMU listable Jiri Olsa <jolsa@redhat.com> - 2016-08-31 09:00 +0200
  [PATCH V6 2/5] perf tools: adding coresight etm PMU record capabilities Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-08-25 22:30 +0200
  [PATCH V6 3/5] perf tools: add infrastructure for PMU specific configuration Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-08-25 22:30 +0200
  [PATCH V6 5/5] perf tools: adding sink configuration for cs_etm PMU Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-08-25 22:30 +0200
    Re: [PATCH V6 5/5] perf tools: adding sink configuration for cs_etm  PMU Jiri Olsa <jolsa@redhat.com> - 2016-08-28 16:20 +0200
      Re: [PATCH V6 5/5] perf tools: adding sink configuration for cs_etm PMU Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-08-29 18:00 +0200
  [PATCH V6 4/5] perf tools: Pushing configuration down to PMU driver Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-08-25 22:30 +0200
  Re: [PATCH V6 0/5] perf: Driver specific configuration for PMU Jiri Olsa <jolsa@redhat.com> - 2016-08-28 16:20 +0200
    Re: [PATCH V6 0/5] perf: Driver specific configuration for PMU Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-08-29 18:00 +0200

csiph-web