Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1471936
| Path | csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Linus Torvalds <torvalds@linux-foundation.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] mm/usercopy: enable usercopy size checking for modern versions of gcc |
| Date | Mon, 29 Aug 2016 17:40:02 +0200 |
| Message-ID | <sbwPg-BA-39@gated-at.bofh.it> (permalink) |
| References | <s9mqZ-6hm-5@gated-at.bofh.it> <s9pyx-8gG-1@gated-at.bofh.it> <s9xmp-50I-3@gated-at.bofh.it> <sa9UK-619-13@gated-at.bofh.it> <saf46-Zl-9@gated-at.bofh.it> <sagtc-1KQ-9@gated-at.bofh.it> <sapG9-7Ij-9@gated-at.bofh.it> <sapPQ-7Lt-15@gated-at.bofh.it> <sawxX-3Rz-3@gated-at.bofh.it> <sazPb-5US-7@gated-at.bofh.it> <sbw2S-62-31@gated-at.bofh.it> |
| X-Original-To | Josh Poimboeuf <jpoimboe@redhat.com> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Qv46SgmVs3M9fN4Pqowm/JLRHuHQe5QsjUJm0Qm79sU=; b=sKE/+DlhcZf62mo2oapKShwN/I63grw/ZvxiAvFP7hVLUMSJX6Oex640Qrzk0QPi7D QAFpXuQUnDQ/x86CB4aCigbZMCcmN61c7pRVXiEKpJ/S8uWj5aQixe1g/j6/MFNa2e2B SLdWMhLLduu9RUEYSmFMUwKEFRNBPVrPH7onSvL7mVKhaX79s2zlBJ0woDEvkDLtOa1F tN9B4suzlxd5MiV1xmGyCutDJxK+b9068PJBS+TdXpqFRXaVdHqKmZcfrpT0ZQKNsnro 8o1L6oQa2PAawkZFcgWBmxNdFGkxXsw8Qca61vkis19Jx+gRflRVLsbm68iPiNl2pDrg gRvg== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Qv46SgmVs3M9fN4Pqowm/JLRHuHQe5QsjUJm0Qm79sU=; b=gnZ5tyWvAbw9mERv7pFLA+9Ape+BuxkjclvVVBlsWdTO8h6SSEZ/YRYKgY8Lb5Lbbo o8xifIytnLXPL5KI9hma2rzjJS+G39kUiJ80cck01q82MA1cUxPSNwuD+yeb7pD1j3Pe exwBwkTDkYwJoJjJz/LvtzQCE4MOV03WVa38r88N8xv0WruyIqBFnDU6UuArEEz33+MG s/UUdctZdVS4zJeVATIMprCec8Lz377dlcwWD18ttRpG4uLSHG5PE5z72pYUUEcsHi3c tw/ru0Nv/1KA/DfpqN7hwCerZGxQ9pCzj00rpz3L4ZwmS2u+WObwr8QHuuXSWaW5Mod0 zyOA== |
| X-Gm-Message-State | AE9vXwOid6Twq3isEiL0XJF0zPwsTH41SXKHpCZh0kAYDNy+jqzPPpReoCE1gLpgTORNlyj8oecw+TdGEeAw6A== |
| X-Received | by 10.202.88.139 with SMTP id m133mr11592810oib.195.1472485007814; Mon, 29 Aug 2016 08:36:47 -0700 (PDT) |
| MIME-Version | 1.0 |
| X-Google-Sender-Auth | oWAglCKUwi2MVb219wwKBNtGKA4 |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 27 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Kees Cook <keescook@chromium.org>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>, "x86@kernel.org" <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>, Andy Lutomirski <luto@amacapital.net>, Steven Rostedt <rostedt@goodmis.org>, Brian Gerst <brgerst@gmail.com>, Peter Zijlstra <peterz@infradead.org>, Frederic Weisbecker <fweisbec@gmail.com>, Byungchul Park <byungchul.park@lge.com>, Nilay Vaish <nilayvaish@gmail.com> |
| X-Original-Date | Mon, 29 Aug 2016 08:36:46 -0700 |
| X-Original-Message-ID | <CA+55aFxfE3_n08XPqys3j6PxcSfn=Mds1v-SXjO9umWnjsQN7A@mail.gmail.com> |
| X-Original-References | <20160823160629.pgnwzl65zji5l76w@treble> <dbdf3c8a1d2339659cdfc0004d6a224eb9cf3175.1471980266.git.jpoimboe@redhat.com> <CAGXu5j+Q8kTWu1t5t8BgC2+zgExr4s4mB7m5Mo6MzOj0hoQ-cw@mail.gmail.com> <20160825204759.fxgbdodqpl55fnji@treble> <CAGXu5jKpzgDooY+q33HTGipFvP25m7GxJT-avCSY6magAR+u=A@mail.gmail.com> <20160826032729.pbubh5imtpocwjc7@treble> <CAGXu5j+gDtUEFiQhpVnFk3-1QxVRM3KXOG2hu3UdLj0DJ3xccA@mail.gmail.com> <20160826135533.odypm5rb7irjk3x5@treble> <20160826205627.bugn5xzjiaebwjar@treble> <CA+55aFxy6D=cgP4bUObQ2Yg5Z+Hc__rXDD6OeKqanLwuk07WxA@mail.gmail.com> <20160829144801.nufhyoq5paqffgdc@treble> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1471936 |
Show key headers only | View raw
On Mon, Aug 29, 2016 at 7:48 AM, Josh Poimboeuf <jpoimboe@redhat.com> wrote:
>
> So I *think* your patch fixes the wrong problem. That's probably at
> least somewhat my fault because I misunderstood the issue before and may
> have described it wrong at some point.
>
> AFAICT, gcc isn't doing anything wrong, and the false positives are
> "intentional".
>
> There are in fact two static warnings (which are being silenced for new
> versions of gcc):
[ snip snip details ]
Ok.
Color me convinced, I never even looked at the two different cases, I
thought it was just one issue.
Let's just remove the spurious false positive warning then, in order
to re-instate the *actual* warning that right now is disabled entirely
due to the unrelated false positives.
Thanks for looking into this. Would you happen to also have a patch
that can be applied? Hint hint..
Linus
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 2/2] mm/usercopy: enable usercopy size checking for modern versions of gcc Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-25 23:00 +0200
Re: [PATCH 2/2] mm/usercopy: enable usercopy size checking for modern versions of gcc Kees Cook <keescook@chromium.org> - 2016-08-26 04:30 +0200
Re: [PATCH 2/2] mm/usercopy: enable usercopy size checking for modern versions of gcc Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-26 06:00 +0200
Re: [PATCH 2/2] mm/usercopy: enable usercopy size checking for modern versions of gcc Kees Cook <keescook@chromium.org> - 2016-08-26 15:50 +0200
Re: [PATCH 2/2] mm/usercopy: enable usercopy size checking for modern versions of gcc Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-26 16:00 +0200
Re: [PATCH 2/2] mm/usercopy: enable usercopy size checking for modern versions of gcc Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-26 23:10 +0200
Re: [PATCH 2/2] mm/usercopy: enable usercopy size checking for modern versions of gcc Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-26 23:10 +0200
Re: [PATCH 2/2] mm/usercopy: enable usercopy size checking for modern versions of gcc Linus Torvalds <torvalds@linux-foundation.org> - 2016-08-27 02:40 +0200
Re: [PATCH 2/2] mm/usercopy: enable usercopy size checking for modern versions of gcc Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-29 16:50 +0200
Re: [PATCH 2/2] mm/usercopy: enable usercopy size checking for modern versions of gcc Linus Torvalds <torvalds@linux-foundation.org> - 2016-08-29 17:40 +0200
[PATCH v2] mm/usercopy: get rid of CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-29 19:10 +0200
Re: [PATCH v2] mm/usercopy: get rid of CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-29 20:10 +0200
[PATCH v3] mm/usercopy: get rid of CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-30 15:10 +0200
Re: [PATCH v3] mm/usercopy: get rid of CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Linus Torvalds <torvalds@linux-foundation.org> - 2016-08-30 19:10 +0200
Re: [PATCH v3] mm/usercopy: get rid of CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Kees Cook <keescook@chromium.org> - 2016-08-30 20:20 +0200
Re: [PATCH v3] mm/usercopy: get rid of CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-30 21:10 +0200
Re: [PATCH v3] mm/usercopy: get rid of CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Kees Cook <keescook@chromium.org> - 2016-08-30 21:30 +0200
Re: [PATCH v3] mm/usercopy: get rid of CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Al Viro <viro@ZenIV.linux.org.uk> - 2016-08-30 22:20 +0200
Re: [PATCH v3] mm/usercopy: get rid of CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Kees Cook <keescook@chromium.org> - 2016-08-31 00:30 +0200
Re: [PATCH v3] mm/usercopy: get rid of CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Mark Rutland <mark.rutland@arm.com> - 2016-08-31 11:50 +0200
Re: [PATCH v3] mm/usercopy: get rid of CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Linus Torvalds <torvalds@linux-foundation.org> - 2016-08-30 20:20 +0200
Re: [PATCH v3] mm/usercopy: get rid of CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Al Viro <viro@ZenIV.linux.org.uk> - 2016-08-30 20:20 +0200
Re: [PATCH 2/2] mm/usercopy: enable usercopy size checking for modern versions of gcc Kees Cook <keescook@chromium.org> - 2016-08-30 20:40 +0200
csiph-web