Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1471838
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Linus Walleij <linus.walleij@linaro.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] video: ARM CLCD: export symbols for driver module |
| Date | Mon, 29 Aug 2016 15:30:02 +0200 |
| Message-ID | <sbuNs-7PD-31@gated-at.bofh.it> (permalink) |
| References | <saryj-xK-51@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Qlbr1hKwW/3123WWUXC57tSqWjuRjLTMvutPS1dgIHU=; b=DKOZKHnmiw2cdHDZkMMiisbYx5p9OFno8N/IF9q+FkYtquNz97LjoTatZTsIJRfkQ7 2eaLIjZbDaxYLCvSx1mRvNe+STqCrE/rzVTWpE4mGTkNzYFp3XKpShsWkzTQybrpjzHk 08+ZXKz3kjG3zYdjKWJkt6PeTcSsmrfjPtQ+8= |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Qlbr1hKwW/3123WWUXC57tSqWjuRjLTMvutPS1dgIHU=; b=fYeLZpVYfZxaJyDCtALRGwkh/2hVW4sfOYqygk1yrLH7MulRaYbQ4Ted+Hm/gRUTip bLAs19kqp0UVXYWb00yaFzgGVaiuQJEP830zZuGPY8x+nxMYa7uVeJoRIXQ/CYEoQqgb 78Wj0cdeYHoccvmvLS9cTc3M3SL6+FIG/0dyLh2ll7pb5PkCtssqIYSseebJnuzbu83Y 0SrK6y4RlIiRclr8N+oPlUdjQcfLKWcK6Kmyxve49zrUyiLw7wpIdKnusH8gU02y0guI qlqvigclhT6iQBKhMobkPK9V0Up4JCnA97Nf6dFoOu9uVoaNYSBGrPMZh9Q26g9jJuVp RRIg== |
| X-Gm-Message-State | AE9vXwPq42QpX/A3SBuLekAjE1HzWPqPRcStBFlFi7dcY7Fpv0DxKCM6nijzb81LMkwyrX9iwTUz9sYTe9gAN/yI |
| X-Received | by 10.157.63.180 with SMTP id r49mr7225240otc.140.1472476837545; Mon, 29 Aug 2016 06:20:37 -0700 (PDT) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 32 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Tomi Valkeinen <tomi.valkeinen@ti.com>, Russell King <linux@armlinux.org.uk>, Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>, "linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> |
| X-Original-Date | Mon, 29 Aug 2016 15:20:36 +0200 |
| X-Original-Message-ID | <CACRpkda8_qRPEniZ86M=AZhfsaj7M1xmx3hjf89k_Euq_jOuXw@mail.gmail.com> |
| X-Original-References | <20160826153500.768744-1-arnd@arndb.de> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1471838 |
Show key headers only | View raw
On Fri, Aug 26, 2016 at 5:34 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The amba-clcd-versatile.c code is always built-in and has to
> be done that way because it gets called by platform code that is
> also built-in. However, it now also gets called from the
> core CLCD driver through the .init_panel callback function,
> which leads to a build error when the framebuffer is configured
> as a loadable module:
>
> ERROR: "versatile_clcd_init_panel" [drivers/video/fbdev/amba-clcd-mod.ko] undefined!
>
> The same thing happens for the nomadik driver, although that
> could be linked into the core module if we want to:
>
> ERROR: "nomadik_clcd_init_panel" [drivers/video/fbdev/amba-clcd.ko] undefined!
> ERROR: "nomadik_clcd_init_board" [drivers/video/fbdev/amba-clcd.ko] undefined!
>
> For consistency, I'm taking the same approach in both cases here
> and just export the functions to make them usable by the driver.
>
> Alternatively, we could split out the CONFIG_OF-code from amba-clcd-versatile.c
> into a new file and link those two together with the core driver as one
> module.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 1d3f0cbe0d3a ("video: ARM CLCD: add special board and panel hooks for Nomadik")
> Fixes: 25348160e9a4 ("video: ARM CLCD: add special panel hook for Versatiles")
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] video: ARM CLCD: export symbols for driver module Arnd Bergmann <arnd@arndb.de> - 2016-08-26 17:50 +0200 Re: [PATCH] video: ARM CLCD: export symbols for driver module Linus Walleij <linus.walleij@linaro.org> - 2016-08-29 15:30 +0200 Re: [PATCH] video: ARM CLCD: export symbols for driver module Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-08-30 11:00 +0200
csiph-web