Re: [PATCH v2] mtd: spi-nor: Add s25fs256s1 spi-nor flash support

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Jagan Teki <jagannadh.teki@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] mtd: spi-nor: Add s25fs256s1 spi-nor flash support
Date	Mon, 29 Aug 2016 15:30:02 +0200
Message-ID	<sbuNs-7PD-27@gated-at.bofh.it> (permalink)
References	<s3BVL-7VO-1@gated-at.bofh.it> <s76qm-8dD-19@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=p/rzI3Q3N7p4Za35o6xL7JbRZd+oIrMqnwibesCfG6E=; b=VovrRy6Qlp3T13CK4XsW3z0p/v55aBHemYQVQ7PdFWNVeIqNrObsdhpkC3vZpx2pmt 9uMEdhhaIYMbcUgUIvr8W9IDPOvWrBSQJ6GLp1xUW2Y4QW1SvCIKanilXwIsl5YTIzTZ pcedHdOatj1PnSlNvUvVWKf8RpykAJM2Dy4+TM2/b4Hg992FeCTr+anbYPCx1HWXH8Vr CH9Om5jYgb/hpvD7/UVNsHhfV3WFxyMGDDQDgQlfw/GUtl9mTz4Rvf6deBAriKWjuDus XE2IPQHKJsx16GTSfM4/bppy2UL3wX8237yWyCPOHLgntvm462GM/vsZvkBExxGVcpUM vsjw==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=p/rzI3Q3N7p4Za35o6xL7JbRZd+oIrMqnwibesCfG6E=; b=mr4Eu47rPdtbfMewCOw1qgenHUZCAAP4YlPxq64KoXRS33vE/9XWAmFCeLOnaRGV7T ShCISyciSo6Abv3R3/SmQ5rI783cwgD6Yrsf8utvG2z9lSFzg5YbS7flYBR1rQ9xsKj5 bCmM5RLdMX42+V/xj6P/A0gaxk+sIuBJFpOVQzsWcv5Mst69Czu2N4vlOqe+ch3lh1FP ri64Z5VUN86VFOERebj3QPU/MadOe7HeO0l3dWg4ATLnAthASw1Kcr7LPvWOQtIl2q4o iMH7vhIjPMMDuPtrx6W8VTl5CsafaAYbBwLlFlb0+gNPo3UHICmh7G71gyjx86YKpVIQ pPfQ==
X-Gm-Message-State	AE9vXwP1PiT013WYOI/oF1YMv5OsnA+mGR78L8bHVCP42nscmYO8ld0GJZ9GpVqgnd9Bjy0cFEd11x1D+Fhm4Q==
X-Received	by 10.46.33.8 with SMTP id h8mr5038483ljh.36.1472477069122; Mon, 29 Aug 2016 06:24:29 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>, Michael Trimarchi <michael@amarulasolutions.com>, Brian Norris <computersforpeace@gmail.com>, David Woodhouse <dwmw2@infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Mon, 29 Aug 2016 18:54:28 +0530
X-Original-Message-ID	<CAD6G_RQmTJrT0AneZp1h+4Vc5f5d83Lp=be-6SSB7fAoweZg1A@mail.gmail.com>
X-Original-References	<1470597730-10400-1-git-send-email-jteki@openedev.com> <VI1PR0401MB2640FF70F5770AEB32F7449E94140@VI1PR0401MB2640.eurprd04.prod.outlook.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1471836

Show key headers only | View raw

On Wed, Aug 17, 2016 at 2:27 PM, Yunhui Cui <yunhui.cui@nxp.com> wrote:
>
> On Monday, August 08, 2016 3:22 AM, Jagan Teki wrote:
>
>> Add Spansion s25fs256s1 spi-nor flash to the list of spi_nor_ids.
>>
>> In spansion S25FS-S family the physical sectors are grouped as normal and
>> parameter sectors. Parameter sectors are 4kB in size with 8 set located
>> at the bottom or top address of a device.
>> Normal sectors are similar to other flash family with sizes of 64kB or 32
>> kB.
>>
>> To erase whole flash using sector erase(D8h or DCh) won't effect the
>> parameter sectors, so in order to erase these we must use 4K sector erase
>> commands (20h or 21h) separately.
>>
>> So better to erase the whole flash using 4K sector erase instead of
>> detecting these family parts again and do two different erase operations.
>>
>> Cc: Brian Norris <computersforpeace@gmail.com>
>> Cc: Yunhui Cui <yunhui.cui@nxp.com>
>> Cc: Michael Trimarchi <michael@amarulasolutions.com>
>> Signed-off-by: Jagan Teki <jteki@openedev.com>
>> ---
>> Changes for v2:
>>       - Fix wrong vendor name in commit message
>
> [Yunhui] Actually, This flash is belongs to S25FS-S Family, besides,
> S25FS128S 128 Mbit (16 Mbyte)
> S25FS256S 256 Mbit (32 Mbyte)
> S25FS512S 512 Mbit (64 Mbyte)
> They need some specific operations, not the Spansion S25FL128S Family.

Please point what exactly the specific ops? because I observed S25FL
vs S25FS have change in a way that they erase the whole flash.

-- 
Jagan Teki.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2] mtd: spi-nor: Add s25fs256s1 spi-nor flash support Jagan Teki <jagannadh.teki@gmail.com> - 2016-08-29 15:30 +0200

csiph-web