Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1471828
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/5] video: ARM CLCD: fix endpoint lookup logic |
| Date | 2016-08-29 15:20 +0200 |
| Message-ID | <sbuDL-7Mi-5@gated-at.bofh.it> (permalink) |
| References | <sareW-qT-7@gated-at.bofh.it> <sareW-qT-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Aug 26, 2016 at 5:25 PM, Arnd Bergmann <arnd@arndb.de> wrote:
[I don't see why Torvalds was CC'ed on this patch? Was there
some specific complaint from his side that I screw things up
or just the wrong Linus?]
> The addition of the Nomadik support in this driver introduced
> a bug in clcdfb_of_init_display(), which now calls init_panel
> with an uninitialized 'endpoint' pointer, as "gcc -Wmaybe-uninitialized"
> warns:
>
> drivers/video/fbdev/amba-clcd.c: In function 'clcdfb_of_init_display':
> drivers/video/fbdev/amba-clcd.c:785:5: error: 'endpoint' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> This reverts the broken part of the function to what it was before
> the patch, which is the best guess I have to what it should be.
> I assume this was left over from an attempted rework of the
> code that was partially backed out.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 046ad6cdeb3f ("video: ARM CLCD: support Nomadik variant")
> Cc: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Tomi: I think this bug was also reported by Ian King, so suggest
adding his
Reported-by: Colin Ian King <colin.king@canonical.com>
When applying.
Yours,
Linus Walleij
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/5] video: ARM CLCD: fix endpoint lookup logic Arnd Bergmann <arnd@arndb.de> - 2016-08-26 17:30 +0200
Re: [PATCH 2/5] video: ARM CLCD: fix endpoint lookup logic Linus Walleij <linus.walleij@linaro.org> - 2016-08-29 15:20 +0200
Re: [PATCH 2/5] video: ARM CLCD: fix endpoint lookup logic Arnd Bergmann <arnd@arndb.de> - 2016-08-29 15:50 +0200
Re: [PATCH 2/5] video: ARM CLCD: fix endpoint lookup logic Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-08-30 10:40 +0200
csiph-web