Re: [PATCH] fix:mailbox:bcm-pdc-mailbox:mark symbols static where possible

From	Arnd Bergmann <arnd@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] fix:mailbox:bcm-pdc-mailbox:mark symbols static where possible
Date	2016-08-29 13:10 +0200
Message-ID	<sbsBX-6z7-15@gated-at.bofh.it> (permalink)
References	<saPqV-7k0-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sunday, August 28, 2016 1:15:24 AM CEST Baoyou Xie wrote:
> We get 2 warnings when biuld kernel with W=1:
> drivers/mailbox/bcm-pdc-mailbox.c:472:6: warning: no previous prototype for 'pdc_setup_debugfs' [-Wmissing-prototypes]
> drivers/mailbox/bcm-pdc-mailbox.c:488:6: warning: no previous prototype for 'pdc_free_debugfs' [-Wmissing-prototypes]
> 
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> 

Acked-by: Arnd Bergmann <arnd@arndb.de>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] fix:mailbox:bcm-pdc-mailbox:mark symbols static where possible Baoyou Xie <baoyou.xie@linaro.org> - 2016-08-27 19:20 +0200
  Re: [PATCH] fix:mailbox:bcm-pdc-mailbox:mark symbols static where possible Arnd Bergmann <arnd@linaro.org> - 2016-08-29 13:10 +0200

csiph-web