Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1471691

Re: [v4.7.2: Oops] When loading IT87 HARDWARE MONITORING DRIVER

From Jean Delvare <jdelvare@suse.de>
Newsgroups linux.kernel
Subject Re: [v4.7.2: Oops] When loading IT87 HARDWARE MONITORING DRIVER
Date 2016-08-29 12:10 +0200
Message-ID <sbrFT-5Yf-1@gated-at.bofh.it> (permalink)
References <saObv-6nq-1@gated-at.bofh.it>
Organization SUSE Linux

Show all headers | View raw


Hello Alexander,

On Sat, 27 Aug 2016 18:52:42 +0300, Alexander Kapshuk wrote:
> I get an Oops when loading it87.ko on a 4.7.2 kernel. See below for details:

it87_attributes_in lacks its NULL terminator, looks suspicious to me.
Can you try the following quick fix?

---
 drivers/hwmon/it87.c |    1 +
 1 file changed, 1 insertion(+)

--- linux-4.7.orig/drivers/hwmon/it87.c	2016-07-04 08:01:00.000000000 +0200
+++ linux-4.7/drivers/hwmon/it87.c	2016-08-29 12:04:52.926911625 +0200
@@ -2015,6 +2015,7 @@ static struct attribute *it87_attributes
 	&sensor_dev_attr_in10_input.dev_attr.attr,	/* 41 */
 	&sensor_dev_attr_in11_input.dev_attr.attr,	/* 41 */
 	&sensor_dev_attr_in12_input.dev_attr.attr,	/* 41 */
+	NULL
 };
 
 static const struct attribute_group it87_group_in = {

I'm trying to find when the bug was introduced. I have a hard time
believing it went unnoticed for long. If it fixes your problem I'll
send a clean patch.

-- 
Jean Delvare
SUSE L3 Support

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[v4.7.2: Oops] When loading IT87 HARDWARE MONITORING DRIVER Alexander Kapshuk <alexander.kapshuk@gmail.com> - 2016-08-27 18:00 +0200
  Re: [v4.7.2: Oops] When loading IT87 HARDWARE MONITORING DRIVER Jean Delvare <jdelvare@suse.de> - 2016-08-29 12:10 +0200
    Re: [v4.7.2: Oops] When loading IT87 HARDWARE MONITORING DRIVER Jean Delvare <jdelvare@suse.de> - 2016-08-29 12:20 +0200
      Re: [v4.7.2: Oops] When loading IT87 HARDWARE MONITORING DRIVER Alexander Kapshuk <alexander.kapshuk@gmail.com> - 2016-08-29 12:20 +0200
      Re: [v4.7.2: Oops] When loading IT87 HARDWARE MONITORING DRIVER Guenter Roeck <linux@roeck-us.net> - 2016-08-29 16:50 +0200
        Re: [v4.7.2: Oops] When loading IT87 HARDWARE MONITORING DRIVER Jean Delvare <jdelvare@suse.de> - 2016-08-29 18:10 +0200

csiph-web