Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1471665

[PATCH 0/3] nvme power saving

Show all headers | View raw

Hi all-

Here's v1 of the APST patch set.  The biggest bikesheddable thing (I
think) is the scaling factor.  I currently have it hardcoded so that
we wait 50x the total latency before entering a power saving state.
On my Samsung 950, this means we enter state 3 (70mW, 0.5ms entry
latency, 5ms exit latency) after 275ms and state 4 (5mW, 2ms entry
latency, 22ms exit latency) after 1200ms.  I have the default max
latency set to 25ms.

FWIW, in practice, the latency this introduces seems to be well
under 22ms, but my benchmark is a bit silly and I might have
measured it wrong.  I certainly haven't observed a slowdown just
using my laptop.

Andy Lutomirski (3):
  nvme/scsi: Remove power management support
  nvme: Pass pointers, not dma addresses, to nvme_get/set_features()
  nvme: Enable autonomous power state transitions

 drivers/nvme/host/core.c | 199 +++++++++++++++++++++++++++++++++++++++++++++--
 drivers/nvme/host/nvme.h |  10 ++-
 drivers/nvme/host/scsi.c |  80 ++-----------------
 include/linux/nvme.h     |   6 ++
 4 files changed, 211 insertions(+), 84 deletions(-)

-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] nvme power saving Andy Lutomirski <luto@kernel.org> - 2016-08-29 11:30 +0200
  [PATCH 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features() Andy Lutomirski <luto@kernel.org> - 2016-08-29 11:30 +0200
    Re: [PATCH 2/3] nvme: Pass pointers, not dma addresses, to  nvme_get/set_features() Keith Busch <keith.busch@intel.com> - 2016-08-29 18:20 +0200
      Re: [PATCH 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features() Andy Lutomirski <luto@amacapital.net> - 2016-08-30 01:30 +0200
        Re: [PATCH 2/3] nvme: Pass pointers, not dma addresses, to         nvme_get/set_features() Christoph Hellwig <hch@lst.de> - 2016-08-30 08:40 +0200
          Re: [PATCH 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features() Andy Lutomirski <luto@amacapital.net> - 2016-08-30 18:10 +0200
  [PATCH 1/3] nvme/scsi: Remove power management support Andy Lutomirski <luto@kernel.org> - 2016-08-29 11:30 +0200

csiph-web