Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1472632
| From | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] net: pegasus: Remove deprecated create_singlethread_workqueue |
| Date | 2016-08-30 18:40 +0200 |
| Message-ID | <sbUeS-7ka-37@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
The workqueue "pegasus_workqueue" queues a single work item per pegasus
instance and hence it doesn't require execution ordering. Hence,
alloc_workqueue has been used to replace the deprecated
create_singlethread_workqueue instance.
The WQ_MEM_RECLAIM flag has been set to ensure forward progress under
memory pressure since it's a network driver.
Since there are fixed number of work items, explicit concurrency
limit is unnecessary here.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/net/usb/pegasus.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c
index 9bbe0161..1434e5d 100644
--- a/drivers/net/usb/pegasus.c
+++ b/drivers/net/usb/pegasus.c
@@ -1129,7 +1129,8 @@ static int pegasus_probe(struct usb_interface *intf,
return -ENODEV;
if (pegasus_count == 0) {
- pegasus_workqueue = create_singlethread_workqueue("pegasus");
+ pegasus_workqueue = alloc_workqueue("pegasus", WQ_MEM_RECLAIM,
+ 0);
if (!pegasus_workqueue)
return -ENOMEM;
}
--
2.1.4
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] net: pegasus: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-30 18:40 +0200
Re: [PATCH] net: pegasus: Remove deprecated create_singlethread_workqueue Petko Manolov <petkan@mip-labs.com> - 2016-08-30 18:50 +0200
Re: [PATCH] net: pegasus: Remove deprecated create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-08-31 16:30 +0200
Re: [PATCH] net: pegasus: Remove deprecated create_singlethread_workqueue Petko Manolov <petkan@mip-labs.com> - 2016-08-31 16:30 +0200
Re: [PATCH] net: pegasus: Remove deprecated create_singlethread_workqueue David Miller <davem@davemloft.net> - 2016-09-02 01:50 +0200
csiph-web