Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1472512
| From | Daniel Wagner <daniel.wagner@bmw-carit.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 2/3] tracing: Add trace_irqsoff tracepoints |
| Date | 2016-08-30 16:30 +0200 |
| Message-ID | <sbSd4-64E-17@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <sboI1-3X9-9@gated-at.bofh.it> <sbrmx-5BR-9@gated-at.bofh.it> <sbNQ5-32D-3@gated-at.bofh.it> <sbRK1-5BB-15@gated-at.bofh.it> <sbRTH-5Ua-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 08/30/2016 04:01 PM, Daniel Wagner wrote:
> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> index 03c0a48..ab8958f 100644
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -152,7 +152,8 @@ EXPORT_SYMBOL_GPL(trace_define_field);
>
> #define __generic_field(type, item, filter_type) \
> ret = __trace_define_field(&ftrace_generic_fields, #type, \
> - #item, 0, 0, is_signed_type(type), \
> + #item, 0, sizeof(type), \
> + is_signed_type(type), \
> filter_type); \
> if (ret) \
> return ret;
>
>
> After that I get this funky report (with only 4 cpus):
Just setting the size of the type is not enough. The hist_field_*
getter function want to know the offset too:
#define DEFINE_HIST_FIELD_FN(type) \
static u64 hist_field_##type(struct hist_field *hist_field, void *event)\
{ \
type *addr = (type *)(event + hist_field->field->offset); \
\
return (u64)(unsigned long)*addr; \
}
The problem we have here is that there is no cpu field in the event
record.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 0/3] *** Latency histograms - IRQSOFF,PREEMPTOFF *** Binoy Jayan <binoy.jayan@linaro.org> - 2016-08-29 09:00 +0200
[PATCH v3 2/3] tracing: Add trace_irqsoff tracepoints Binoy Jayan <binoy.jayan@linaro.org> - 2016-08-29 09:00 +0200
Re: [PATCH v3 2/3] tracing: Add trace_irqsoff tracepoints Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-08-29 11:50 +0200
Re: [PATCH v3 2/3] tracing: Add trace_irqsoff tracepoints Binoy Jayan <binoy.jayan@linaro.org> - 2016-08-30 11:50 +0200
Re: [PATCH v3 2/3] tracing: Add trace_irqsoff tracepoints Steven Rostedt <rostedt@goodmis.org> - 2016-08-30 16:00 +0200
Re: [PATCH v3 2/3] tracing: Add trace_irqsoff tracepoints Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-08-30 16:10 +0200
Re: [PATCH v3 2/3] tracing: Add trace_irqsoff tracepoints Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-08-30 16:30 +0200
Re: [PATCH v3 2/3] tracing: Add trace_irqsoff tracepoints Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-08-30 17:10 +0200
Re: [PATCH v3 2/3] tracing: Add trace_irqsoff tracepoints Steven Rostedt <rostedt@goodmis.org> - 2016-08-30 23:10 +0200
Re: [PATCH v3 2/3] tracing: Add trace_irqsoff tracepoints Binoy Jayan <binoy.jayan@linaro.org> - 2016-08-31 08:10 +0200
[PATCH v3 1/3] tracing: Deference pointers without RCU checks Binoy Jayan <binoy.jayan@linaro.org> - 2016-08-29 09:00 +0200
[PATCH v3 3/3] tracing: Histogram for missed timer offsets Binoy Jayan <binoy.jayan@linaro.org> - 2016-08-29 09:10 +0200
csiph-web