Re: [PATCH 25/26] clk: boston: Add a driver for MIPS Boston board clocks

From	Paul Burton <paul.burton@imgtec.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 25/26] clk: boston: Add a driver for MIPS Boston board clocks
Date	2016-08-30 17:10 +0200
Message-ID	<sbSPM-6x2-27@gated-at.bofh.it> (permalink)
References	<saroB-ua-5@gated-at.bofh.it> <saryj-xK-65@gated-at.bofh.it> <satqp-1GW-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 26/08/16 18:41, Stephen Boyd wrote:
>> +	if (err)
>> +		pr_err("failed to add DT provider: %d\n", err);
>> +}
>> +CLK_OF_DECLARE(clk_boston, "img,boston-clock", clk_boston_setup);
> 
> Please make this into a platform driver.

Hi Stephen,

The problem with this would be that we need to obtain the CPU clock rate
fairly early during boot in order to set up the clocksource & delay loop
etc. Using CLK_OF_DECLARE allows for that but if this were a platform
driver my understanding is that the clocks wouldn't become available
until some point later in boot. If I'm wrong & there's a way to avoid
that please let me know.

Also: why? If CLK_OF_DECLARE isn't liked, shouldn't that be documented
somewhere (ideally next to the declaration of CLK_OF_DECLARE in
include/linux/clk-provider.h)?

Thanks,
    Paul

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 00/26] MIPS generic kernels, SEAD-3 & Boston support Paul Burton <paul.burton@imgtec.com> - 2016-08-26 17:50 +0200
  [PATCH 26/26] MIPS: generic: Support MIPS Boston development boards Paul Burton <paul.burton@imgtec.com> - 2016-08-26 17:50 +0200
  [PATCH 22/26] MIPS: generic: Introduce generic DT-based board support Paul Burton <paul.burton@imgtec.com> - 2016-08-26 17:50 +0200
  [PATCH 19/26] MIPS: Stengthen IPI IRQ domain sanity check Paul Burton <paul.burton@imgtec.com> - 2016-08-26 17:50 +0200
  [PATCH 01/26] MIPS: PCI: Support for CONFIG_PCI_DOMAINS_GENERIC Paul Burton <paul.burton@imgtec.com> - 2016-08-26 17:50 +0200
  [PATCH 13/26] dt-bindings: Document mti,mips-cdmm binding Paul Burton <paul.burton@imgtec.com> - 2016-08-26 17:50 +0200
    Re: [PATCH 13/26] dt-bindings: Document mti,mips-cdmm binding Rob Herring <robh@kernel.org> - 2016-09-02 14:40 +0200
  [PATCH 16/26] irqchip: mips-cpu: Prepare for non-legacy IRQ domains Paul Burton <paul.burton@imgtec.com> - 2016-08-26 17:50 +0200
  [PATCH 20/26] MIPS: Adjust MIPS64 CAC_BASE to reflect Config.K0 Paul Burton <paul.burton@imgtec.com> - 2016-08-26 17:50 +0200
  [PATCH 25/26] clk: boston: Add a driver for MIPS Boston board clocks Paul Burton <paul.burton@imgtec.com> - 2016-08-26 17:50 +0200
    Re: [PATCH 25/26] clk: boston: Add a driver for MIPS Boston board  clocks Stephen Boyd <sboyd@codeaurora.org> - 2016-08-26 19:50 +0200
      Re: [PATCH 25/26] clk: boston: Add a driver for MIPS Boston board  clocks Paul Burton <paul.burton@imgtec.com> - 2016-08-30 17:10 +0200

csiph-web