Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1472422

Re: [PATCH 2/2] drivers/perf: arm_pmu: Fix NULL pointer dereference during probe

Show all headers | View raw

On Sat, Aug 27, 2016 at 04:19:50PM +0000, Stefan Wahren wrote:
> Patch 7f1d642fbb5c ("drivers/perf: arm-pmu: Fix handling of SPI lacking
> interrupt-affinity property") unintended also fixes perf_event support
> for bcm2835 which doesn't have PMU interrupts. Unfortunately this change
> introduce a NULL pointer dereference on bcm2835, because irq_is_percpu
> always expected to be called with a valid IRQ. So fix this regression
> by validating the IRQ before.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Fixes: 7f1d642fbb5c ("drivers/perf: arm-pmu: Fix handling of SPI lacking \"interrupt-affinity\" property")
> ---
>  drivers/perf/arm_pmu.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, these two look good to me. I'll queue them up as fixes and hopefully
they'll land in -rc5.

Will

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] drivers/perf: arm_pmu: Fix NULL pointer dereference during probe Stefan Wahren <stefan.wahren@i2se.com> - 2016-08-27 18:30 +0200
  Re: [PATCH 2/2] drivers/perf: arm_pmu: Fix NULL pointer dereference  during probe Will Deacon <will.deacon@arm.com> - 2016-08-30 13:30 +0200
    Re: [PATCH 2/2] drivers/perf: arm_pmu: Fix NULL pointer dereference during probe Kevin Hilman <khilman@baylibre.com> - 2016-09-01 04:20 +0200

csiph-web