Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1472432

Re: [PATCH v4 2/3] tracing: Add trace_irqsoff tracepoints

Show all headers | View raw

Hi Daniel,

On 30 August 2016 at 17:00, Daniel Wagner <daniel.wagner@bmw-carit.de> wrote:
> Hi Binoy,
>
>
> As Masami has pointed out, the prefix trace_ should not be used. Also having
> trace_latency_ and latency_trace_ is kind of confusing. What about
> {start|stop}_latency_timing()? It would match the existing
> {start|stop}_critical_timing(). Or is it too close and it leads to
> confusion?
>
> Another idea is {start|stop}_latency_preempt(). This matches the
> trace_latency_preempt_enable() function.
>

Sure, I'll make this change. And how about the 'cpu' field not being
available to be used
as a key field or as a value field when we do not define it explicitly
(mentioned in the
other email). Can we live with that ?

Thanks,
Binoy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 2/3] tracing: Add trace_irqsoff tracepoints Binoy Jayan <binoy.jayan@linaro.org> - 2016-08-30 12:30 +0200
  Re: [PATCH v4 2/3] tracing: Add trace_irqsoff tracepoints Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-08-30 13:40 +0200
    Re: [PATCH v4 2/3] tracing: Add trace_irqsoff tracepoints Binoy Jayan <binoy.jayan@linaro.org> - 2016-08-30 13:50 +0200
  Re: [PATCH v4 2/3] tracing: Add trace_irqsoff tracepoints Steven Rostedt <rostedt@goodmis.org> - 2016-08-30 16:10 +0200
    Re: [PATCH v4 2/3] tracing: Add trace_irqsoff tracepoints Binoy Jayan <binoy.jayan@linaro.org> - 2016-08-31 13:40 +0200

csiph-web