[PATCH] [bugfix] replace unnessary ldax with common ldr

From	Kenneth Lee <liguozhu@hisilicon.com>
Newsgroups	linux.kernel
Subject	[PATCH] [bugfix] replace unnessary ldax with common ldr
Date	2016-08-30 08:20 +0200
Message-ID	<sbKyR-15N-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

(add comment for the previous mail, sorry for the duplication)

There is no store_ex pairing with this load_ex. It is not necessary and
gave wrong hint to the cache system.

Signed-off-by: Kenneth Lee <liguozhu@hisilicon.com>
---
 arch/arm64/include/asm/spinlock.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/include/asm/spinlock.h b/arch/arm64/include/asm/spinlock.h
index c85e96d..3334c4f 100644
--- a/arch/arm64/include/asm/spinlock.h
+++ b/arch/arm64/include/asm/spinlock.h
@@ -63,7 +63,7 @@ static inline void arch_spin_lock(arch_spinlock_t *lock)
 	 */
 "	sevl\n"
 "2:	wfe\n"
-"	ldaxrh	%w2, %4\n"
+"	ldrh	%w2, %4\n"
 "	eor	%w1, %w2, %w0, lsr #16\n"
 "	cbnz	%w1, 2b\n"
 	/* We got the lock. Critical section starts here. */
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] [bugfix] replace unnessary ldax with common ldr  Kenneth Lee <liguozhu@hisilicon.com> - 2016-08-30 08:20 +0200
  Re: [PATCH] [bugfix] replace unnessary ldax with common ldr Catalin Marinas <catalin.marinas@arm.com> - 2016-08-30 11:10 +0200
    Re: [PATCH] [bugfix] replace unnessary ldax with common ldr Vladimir Murzin <vladimir.murzin@arm.com> - 2016-08-31 15:40 +0200
      Re: [PATCH] [bugfix] replace unnessary ldax with common ldr Catalin Marinas <catalin.marinas@arm.com> - 2016-09-01 12:30 +0200

csiph-web