Re: [Qemu-devel] [PATCH v2 0/2] vfio: blacklist legacy virtio devices

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	"Michael S. Tsirkin" <mst@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [Qemu-devel] [PATCH v2 0/2] vfio: blacklist legacy virtio devices
Date	Tue, 30 Aug 2016 06:00:07 +0200
Message-ID	<sbInt-7UM-5@gated-at.bofh.it> (permalink)
References	<sbGYh-7dn-1@gated-at.bofh.it> <sbHKF-7I6-1@gated-at.bofh.it>
X-Original-To	Jason Wang <jasowang@redhat.com>
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Disposition	inline
Content-Transfer-Encoding	8bit
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.27
X-Greylist	Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 30 Aug 2016 03:49:52 +0000 (UTC)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	33
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, kvm@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Alex Williamson <alex.williamson@redhat.com>, Cornelia Huck <cornelia.huck@de.ibm.com>
X-Original-Date	Tue, 30 Aug 2016 06:49:51 +0300
X-Original-Message-ID	<20160830064857-mutt-send-email-mst@kernel.org>
X-Original-References	<1472523968-9540-1-git-send-email-mst@redhat.com> <b3183b57-2335-9195-4cf1-bad7b9f30956@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1472216

Show key headers only | View raw

On Tue, Aug 30, 2016 at 11:16:25AM +0800, Jason Wang wrote:
> 
> 
> On 2016年08月30日 10:27, Michael S. Tsirkin wrote:
> > Legacy virtio devices always bypassed an IOMMU, so using them with vfio was
> > never safe.
> 
> And it actually won't work since GPA is assumed in the device. So I'm not
> sure this is must since we should get a IOMMU fault in this case.

We won't get an IOMMU fault for legacy systems since they
bypass the IOMMU. Instead guest userspace will get full
access to all of guest memory through the device.


> >   This adds a quirk detecting these and disabling VFIO unless the
> > noiommu mode is used.  At the moment, this only applies to virtio-pci devices.
> > 
> > The patch might make sense on stable as well.
> > 
> > Michael S. Tsirkin (2):
> >    vfio: report group noiommu status
> >    vfio: add virtio pci quirk
> > 
> >   drivers/vfio/pci/vfio_pci_private.h |   1 +
> >   include/linux/vfio.h                |   2 +
> >   drivers/vfio/pci/vfio_pci.c         |  14 ++++
> >   drivers/vfio/pci/vfio_pci_virtio.c  | 140 ++++++++++++++++++++++++++++++++++++
> >   drivers/vfio/vfio.c                 |  12 ++++
> >   drivers/vfio/pci/Makefile           |   1 +
> >   6 files changed, 170 insertions(+)
> >   create mode 100644 drivers/vfio/pci/vfio_pci_virtio.c
> >

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/2] vfio: blacklist legacy virtio devices "Michael S. Tsirkin" <mst@redhat.com> - 2016-08-30 04:30 +0200
  [PATCH v2 2/2] vfio: add virtio pci quirk "Michael S. Tsirkin" <mst@redhat.com> - 2016-08-30 04:30 +0200
    Re: [PATCH v2 2/2] vfio: add virtio pci quirk Alex Williamson <alex.williamson@redhat.com> - 2016-08-30 05:30 +0200
      Re: [PATCH v2 2/2] vfio: add virtio pci quirk "Michael S. Tsirkin" <mst@redhat.com> - 2016-08-30 05:50 +0200
      Re: [PATCH v2 2/2] vfio: add virtio pci quirk "Michael S. Tsirkin" <mst@redhat.com> - 2016-08-30 06:00 +0200
      Re: [PATCH v2 2/2] vfio: add virtio pci quirk Alex Williamson <alex.williamson@redhat.com> - 2016-08-30 06:00 +0200
        Re: [PATCH v2 2/2] vfio: add virtio pci quirk Alex Williamson <alex.williamson@redhat.com> - 2016-08-30 07:00 +0200
          Re: [PATCH v2 2/2] vfio: add virtio pci quirk "Michael S. Tsirkin" <mst@redhat.com> - 2016-08-30 07:30 +0200
            Re: [PATCH v2 2/2] vfio: add virtio pci quirk Alex Williamson <alex.williamson@redhat.com> - 2016-08-30 14:50 +0200
  [PATCH v2 1/2] vfio: report group noiommu status "Michael S. Tsirkin" <mst@redhat.com> - 2016-08-30 04:30 +0200
  Re: [Qemu-devel] [PATCH v2 0/2] vfio: blacklist legacy virtio devices Jason Wang <jasowang@redhat.com> - 2016-08-30 05:20 +0200
    Re: [Qemu-devel] [PATCH v2 0/2] vfio: blacklist legacy virtio devices "Michael S. Tsirkin" <mst@redhat.com> - 2016-08-30 06:00 +0200

csiph-web