Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1472184
| From | Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] printk/nmi: avoid direct printk()-s from __printk_nmi_flush() |
| Date | 2016-08-30 03:10 +0200 |
| Message-ID | <sbFIR-6oh-1@gated-at.bofh.it> (permalink) |
| References | <sbu14-7js-49@gated-at.bofh.it> <sbwvT-v8-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On (08/29/16 17:16), Petr Mladek wrote:
[..]
> The comment above is not longer valid.
oh, yes. it shouldn't even be there.
> > -static void print_nmi_seq_line(struct nmi_seq_buf *s, int start, int end)
> > +static void __print_nmi_seq_line(const char *text, int len)
>
> Also the name of the function might be confusing because it is not
> longer used only for the seq buffer. I would rename it to
> something like:
>
> printk_nmi_flush_line()
sounds good.
> > +static void print_nmi_seq_line(struct nmi_seq_buf *s, int start, int end)
> > +{
>
> Then I would rename also this function to something like:
>
> printk_nmi_flush_seq_line()
sounds good.
> > + const char *buf = s->buffer + start;
> > +
> > + __print_nmi_seq_line(buf, (end - start) + 1);
> > +}
> > +
>
> Othrewise, it looks fine. With the above suggested changes, feel
> free to add:
>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
thanks, will re-spin today.
-ss
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] printk/nmi: avoid direct printk()-s from __printk_nmi_flush() Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-08-29 14:40 +0200
Re: [PATCH] printk/nmi: avoid direct printk()-s from __printk_nmi_flush() Petr Mladek <pmladek@suse.com> - 2016-08-29 17:20 +0200
Re: [PATCH] printk/nmi: avoid direct printk()-s from __printk_nmi_flush() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-08-30 03:10 +0200
Re: [PATCH] printk/nmi: avoid direct printk()-s from __printk_nmi_flush() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-08-30 10:00 +0200
Re: [PATCH] printk/nmi: avoid direct printk()-s from __printk_nmi_flush() Petr Mladek <pmladek@suse.com> - 2016-08-30 11:10 +0200
Re: [PATCH] printk/nmi: avoid direct printk()-s from __printk_nmi_flush() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-08-30 11:40 +0200
Re: [PATCH] printk/nmi: avoid direct printk()-s from __printk_nmi_flush() Petr Mladek <pmladek@suse.com> - 2016-08-30 13:20 +0200
Re: [PATCH] printk/nmi: avoid direct printk()-s from __printk_nmi_flush() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-08-31 06:10 +0200
Re: [PATCH] printk/nmi: avoid direct printk()-s from __printk_nmi_flush() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-09-01 10:00 +0200
Re: [PATCH] printk/nmi: avoid direct printk()-s from __printk_nmi_flush() Petr Mladek <pmladek@suse.com> - 2016-09-01 10:20 +0200
csiph-web