Re: [PATCH 3/5] firmware: ti_sci: Add support for Device control

From	Santosh Shilimkar <santosh.shilimkar@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/5] firmware: ti_sci: Add support for Device control
Date	2016-08-30 00:40 +0200
Message-ID	<sbDnH-4Pc-1@gated-at.bofh.it> (permalink)
References	<s80Vz-3en-7@gated-at.bofh.it> <s80Vz-3en-15@gated-at.bofh.it> <s8OyZ-W3-1@gated-at.bofh.it> <s9oVP-7Ln-11@gated-at.bofh.it>
Organization	Oracle Corporation

Show all headers | View raw

Hi Nishant,

On 8/23/2016 11:45 AM, Nishanth Menon wrote:
> On Sun, Aug 21, 2016 at 10:56 PM, Lokesh Vutla <lokeshvutla@ti.com> wrote:
>>>  /**
>>> + * tis_sci_is_response_ack() - Generic ACK/NACK message checkup
>>> + * @r:       pointer to response buffer
>>> + *
>>> + * Return: true if the response was an ACK, else returns false.
>>> + */
>>> +static inline bool tis_sci_is_response_ack(void *r)
>>
>> May be just ti_sci_is_response_ack() to be consistent? or you wanted to
>> keep it tis_sci* ?
>
>
> Uggh.. Fat fingered that one.. thanks for catching.. fixed and will
> post a v2 next week if there is no further comments
>
I would like to send the next merge window queue up so please repost
the reviewed patches which needs to be queued up.

Regards,
Santosh

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 3/5] firmware: ti_sci: Add support for Device control Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-08-30 00:40 +0200

csiph-web