Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1472089
| From | Brian Norris <computersforpeace@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] mtd: nand: omap2: Don't call dma_release_channel() if dma_request_chan() failed |
| Date | 2016-08-29 22:10 +0200 |
| Message-ID | <sbB2y-3pN-3@gated-at.bofh.it> (permalink) |
| References | <s6kOJ-2Gt-1@gated-at.bofh.it> <s6rZU-7hs-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Aug 15, 2016 at 05:22:00PM +0200, Boris Brezillon wrote:
> On Mon, 15 Aug 2016 10:47:39 +0300
> Roger Quadros <rogerq@ti.com> wrote:
>
> > dma_request_chan() can fail returning an error pointer. In this case
> > prevent calling dma_release_channel() to prevent a ERR_PTR() dereference.
> >
> > As error path can be called even with no DMA configuration, info->dma can
> > be NULL so don't call dma_release_channel() for that case either.
> >
> > Fixes: de3bfc4a1616: ("mtd: nand: omap2: fix return value check in omap_nand_probe()")
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Roger Quadros <rogerq@ti.com>
>
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>
> Brian, can you apply this fix directly?
Applied to linux-mtd.git
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH] mtd: nand: omap2: Don't call dma_release_channel() if dma_request_chan() failed Brian Norris <computersforpeace@gmail.com> - 2016-08-29 22:10 +0200
csiph-web