Groups > linux.kernel > #1472073

Re: [PATCH] fix:iio:common:st_sensors:st_sensors_trigger:mark symbols static where possible

From	Jonathan Cameron <jic23@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] fix:iio:common:st_sensors:st_sensors_trigger:mark symbols static where possible
Date	2016-08-29 21:20 +0200
Message-ID	<sbAgb-2S5-33@gated-at.bofh.it> (permalink)
References	<saFhT-12j-7@gated-at.bofh.it> <saHto-2iP-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 27/08/16 09:44, Linus Walleij wrote:
> On Sat, Aug 27, 2016 at 8:26 AM, Baoyou Xie <baoyou.xie@linaro.org> wrote:
> 
>> We get 2 warnings when biuld kernel with W=1:
>> drivers/iio/common/st_sensors/st_sensors_trigger.c:69:13: warning: no previous prototype
>> for 'st_sensors_irq_handler' [-Wmissing-prototypes]
>> drivers/iio/common/st_sensors/st_sensors_trigger.c:85:13: warning: no previous prototype
>> for 'st_sensors_irq_thread' [-Wmissing-prototypes]
>>
>> In fact, these functions are only used in the file in which they are
>> declared and don't need a declaration, but can be made static.
>> so this patch marks these functions with 'static'.
>>
>> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Applied to the togreg branch of iio.git. Initially pushed out
as testing for the autobuilders to play with it.

Thanks,

Jonathan
> 
> Yours,
> Linus Walleij
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] fix:iio:common:st_sensors:st_sensors_trigger:mark symbols static where possible Baoyou Xie <baoyou.xie@linaro.org> - 2016-08-27 08:30 +0200
  Re: [PATCH] fix:iio:common:st_sensors:st_sensors_trigger:mark symbols  static where possible Linus Walleij <linus.walleij@linaro.org> - 2016-08-27 10:50 +0200
    Re: [PATCH] fix:iio:common:st_sensors:st_sensors_trigger:mark symbols  static where possible Jonathan Cameron <jic23@kernel.org> - 2016-08-29 21:20 +0200

csiph-web