[PATCH] scsi: ufs: add missing declaration in ufshcd.h

From	Baoyou Xie <baoyou.xie@linaro.org>
Newsgroups	linux.kernel
Subject	[PATCH] scsi: ufs: add missing declaration in ufshcd.h
Date	2016-08-28 10:10 +0200
Message-ID	<sb3kd-7Ae-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

We get 1 warning about global functions without a declaration
in the scsi ufshcd driver when building with W=1:
drivers/scsi/ufs/ufshcd.c:1991:5: warning: no previous prototype for 'ufshcd_query_descriptor_retry' [-Wmissing-prototypes]

in fact, this function is implemented in ufshcd.c and exported
but need to be declared in header file.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 drivers/scsi/ufs/ufshcd.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
index 430bef1..2f696ea 100644
--- a/drivers/scsi/ufs/ufshcd.h
+++ b/drivers/scsi/ufs/ufshcd.h
@@ -713,6 +713,9 @@ int ufshcd_read_string_desc(struct ufs_hba *hba, int desc_index, u8 *buf,
 /* Expose Query-Request API */
 int ufshcd_query_flag(struct ufs_hba *hba, enum query_opcode opcode,
 	enum flag_idn idn, bool *flag_res);
+int ufshcd_query_descriptor_retry(struct ufs_hba *hba,
+	enum query_opcode opcode, enum desc_idn idn, u8 index,
+	u8 selector, u8 *desc_buf, int *buf_len);
 int ufshcd_hold(struct ufs_hba *hba, bool async);
 void ufshcd_release(struct ufs_hba *hba);
 u32 ufshcd_get_local_unipro_ver(struct ufs_hba *hba);
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] scsi: ufs: add missing declaration in ufshcd.h Baoyou Xie <baoyou.xie@linaro.org> - 2016-08-28 10:10 +0200
  Re: [PATCH] scsi: ufs: add missing declaration in ufshcd.h "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-09-02 13:00 +0200

csiph-web