Re: [PATCH v05 06/72] include/uapi/linux/hsi/cs-protocol.h: include linux/time.h

From	Mikko Rapeli <mikko.rapeli@iki.fi>
Newsgroups	linux.kernel
Subject	Re: [PATCH v05 06/72] include/uapi/linux/hsi/cs-protocol.h: include linux/time.h
Date	2016-08-28 09:10 +0200
Message-ID	<sb2o9-71z-1@gated-at.bofh.it> (permalink)
References	<s92iC-1rh-5@gated-at.bofh.it> <s92sj-1v9-75@gated-at.bofh.it> <s94u6-2Ol-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 22, 2016 at 10:52:20PM +0200, Sebastian Reichel wrote:
> Hi,
> 
> On Mon, Aug 22, 2016 at 08:32:23PM +0200, Mikko Rapeli wrote:
> > Fixes userspace compilation errors due to missing timespec definition.
> > 
> > Signed-off-by: Mikko Rapeli <mikko.rapeli@iki.fi>
> > ---
> >  include/uapi/linux/hsi/cs-protocol.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/uapi/linux/hsi/cs-protocol.h b/include/uapi/linux/hsi/cs-protocol.h
> > index f153d6e..c8d9f08 100644
> > --- a/include/uapi/linux/hsi/cs-protocol.h
> > +++ b/include/uapi/linux/hsi/cs-protocol.h
> > @@ -26,6 +26,7 @@
> >  
> >  #include <linux/types.h>
> >  #include <linux/ioctl.h>
> > +#include <linux/time.h>
> >  
> >  /* chardev parameters */
> >  #define CS_DEV_FILE_NAME		"/dev/cmt_speech"
> 
> As far as I can see there header file does not use timespec since
> I removed it roughly a year ago.

Yes, your patch 5023a5ca8e144846ec0646554336000abb11e04f fixes also uapi
compilation errors. This patch from me is not needed and even wrong
for the API.

-Mikko

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v05 06/72] include/uapi/linux/hsi/cs-protocol.h: include  linux/time.h Mikko Rapeli <mikko.rapeli@iki.fi> - 2016-08-28 09:10 +0200

csiph-web