Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1471023
| From | Anson Jacob <ansonjacob.aj@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 3/7] staging: comedi: jr3_pci.h: Fix checkpatch warning |
| Date | 2016-08-27 00:40 +0200 |
| Message-ID | <saxX4-4FV-7@gated-at.bofh.it> (permalink) |
| References | <saucN-2eG-1@gated-at.bofh.it> <saucO-2eG-15@gated-at.bofh.it> <sawRj-3Y5-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, Aug 27, 2016 at 12:23:58AM +0300, Andrey Utkin wrote: > On Fri, Aug 26, 2016 at 02:33:08PM -0400, Anson Jacob wrote: > > > > - /* Default_FS contains the full scale that is used if the user does */ > > - /* not set a full scale. */ > > + /* > > Applying: staging: comedi: jr3_pci.h: Fix checkpatch warning > .git/rebase-apply/patch:226: trailing whitespace. > /* > warning: 1 line adds whitespace errors. > > This means you have a space after asterisk. You would catch this if you run > checkpatch.pl after making your commits. > > Actually, some files you have amended, still have issues of same difficulty. > You are encouraged to sort that out, too. See > > for x in drivers/staging/comedi/drivers/cb_pcidas64.c drivers/staging/comedi/drivers/jr3_pci.c drivers/staging/comedi/drivers/jr3_pci.h drivers/staging/comedi/drivers/ni_at_a2150.c drivers/staging/comedi/drivers/ni_atmio.c drivers/staging/comedi/drivers/s626.h; do ./scripts/checkpatch.pl --strict -f $x; done Thank you for the comments and the code snippet. I only found one trailing whitespace issue in the patchset. I will be uploading a new patchset with the fix for the trailing whitespace. Are my commits are too long. Am I supposed to submit shorter ones.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/7] staging: comedi: Fix checkpatch warning Anson Jacob <ansonjacob.aj@gmail.com> - 2016-08-26 20:40 +0200
[PATCH v2 3/7] staging: comedi: jr3_pci.h: Fix checkpatch warning Anson Jacob <ansonjacob.aj@gmail.com> - 2016-08-26 20:40 +0200
Re: [PATCH v2 3/7] staging: comedi: jr3_pci.h: Fix checkpatch warning Andrey Utkin <andrey_utkin@fastmail.com> - 2016-08-26 23:30 +0200
Re: [PATCH v2 3/7] staging: comedi: jr3_pci.h: Fix checkpatch warning Anson Jacob <ansonjacob.aj@gmail.com> - 2016-08-27 00:40 +0200
Re: [PATCH v2 3/7] staging: comedi: jr3_pci.h: Fix checkpatch warning Andrey Utkin <andrey_utkin@fastmail.com> - 2016-08-27 01:00 +0200
[PATCH v2 6/7] staging: comedi: jr3_pci.c: Fix checkpatch warning Anson Jacob <ansonjacob.aj@gmail.com> - 2016-08-26 20:40 +0200
[PATCH v2 1/7] staging: comedi: cb_pcidas64.c: Fix checkpatch warning Anson Jacob <ansonjacob.aj@gmail.com> - 2016-08-26 20:40 +0200
[PATCH v2 5/7] staging: comedi: s626.h: Fix checkpatch warning Anson Jacob <ansonjacob.aj@gmail.com> - 2016-08-26 20:40 +0200
[PATCH v2 7/7] staging: comedi: ni_at_a2150: Fix checkpatch warning Anson Jacob <ansonjacob.aj@gmail.com> - 2016-08-26 20:40 +0200
[PATCH v2 4/7] staging: comedi: ni_atmio.c: Fix checkpatch warning Anson Jacob <ansonjacob.aj@gmail.com> - 2016-08-26 20:40 +0200
csiph-web