Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1470966

Re: [PATCH] staging/lustre: avoid zero buf for the first time

Show all headers | View raw

Hello!

On Aug 22, 2016, at 6:04 AM, Greg Kroah-Hartman wrote:

> On Mon, Aug 22, 2016 at 04:46:04PM +0800, Shawn Lin wrote:
>> We only need to zero it when repeating in order to
>> avoid old garbage. Let's improve it by moving this
>> before we repeat the calculation to save some cpu
>> cycle.
>> 
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> 
> Have you noticed a change with this in a benchmark?
> 
> If not, is it really worth it?

The other problem is we would need to remember to memset it
should there be more paths jumping to the repeat label
which might be easy to miss,
so we are probably better off without this patch.

> I need an ack from the lustre developers before taking patches like
> this...
> 
> thanks,
> 
> greg k-h

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] staging/lustre: avoid zero buf for the first time Oleg Drokin <oleg.drokin@intel.com> - 2016-08-26 21:50 +0200

csiph-web