Re: [PATCH 2/2] ARM: dts: sun8i: Add extra UART pinmux settings for A23/33

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] ARM: dts: sun8i: Add extra UART pinmux settings for A23/33
Date	2016-08-26 22:30 +0200
Message-ID	<savVf-3pJ-5@gated-at.bofh.it> (permalink)
References	<s9dQJ-lX-11@gated-at.bofh.it> <s9inn-3ui-21@gated-at.bofh.it> <s9inn-3ui-19@gated-at.bofh.it> <savVf-3pJ-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Tue, Aug 23, 2016 at 09:51:05PM +0800, Icenowy Zheng wrote:
> 
> 
> 23.08.2016, 19:42, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
> > Hi,
> >
> > On Tue, Aug 23, 2016 at 01:58:26PM +0800, Icenowy Zheng wrote:
> >>  A23/33 have 4 UART controllers outside PRCM. However, the devicetree used
> >>  to mentioned only UART0's pinmux settings. Some extra UART controllers have
> >>  RTS/CTS, and is suitable for using as bluetooth UART controller.
> >>
> >>  Add the pinmux settings for the UART controller, to make use of the
> >>  bluetooth function of some tablets.
> >>
> >>  Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> >
> > Our policy is that we avoid adding unused pinctrl nodes to not cripple
> > the DT for no particular reason.
> >
> > So please add only the nodes you'll need in your tablet.
> 
> Then... if what I needs is the PG group of uart1, should I name it as
> uart1_pins_a or uart1_pins_b?

We don't have any rules here, whichever comes first wins.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] ARM: dts: sun8i: Add extra UART pinmux settings for  A23/33 Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-08-26 22:30 +0200

csiph-web