Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1470762

[PATCH 1/3] clocksource/drivers/timer-atmel-pit: Enable mck clock

From Daniel Lezcano <daniel.lezcano@linaro.org>
Newsgroups linux.kernel
Subject [PATCH 1/3] clocksource/drivers/timer-atmel-pit: Enable mck clock
Date 2016-08-26 16:30 +0200
Message-ID <saqiR-8az-5@gated-at.bofh.it> (permalink)
References <saqiR-8az-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Alexandre Belloni <alexandre.belloni@free-electrons.com>

mck is needed to get the PIT working. Explicitly prepare_enable it instead
of assuming it is enabled.

This solves an issue where the system is freezing when the ETM/ETB drivers
are enabled.

Reported-by: Olivier Schonken <olivier.schonken@gmail.com>
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/timer-atmel-pit.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c
index 1ffac0c..3494bc5 100644
--- a/drivers/clocksource/timer-atmel-pit.c
+++ b/drivers/clocksource/timer-atmel-pit.c
@@ -261,6 +261,12 @@ static int __init at91sam926x_pit_dt_init(struct device_node *node)
 		return PTR_ERR(data->mck);
 	}
 
+	ret = clk_prepare_enable(data->mck);
+	if (ret) {
+		pr_err("Unable to enable mck\n");
+		return ret;
+	}
+
 	/* Get the interrupts property */
 	data->irq = irq_of_parse_and_map(node, 0);
 	if (!data->irq) {
-- 
1.9.1

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH 1/3] clocksource/drivers/timer-atmel-pit: Enable mck clock Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-08-26 16:30 +0200
  Re: [PATCH 1/3] clocksource/drivers/timer-atmel-pit: Enable mck clock Mark Rutland <mark.rutland@arm.com> - 2016-08-30 12:00 +0200
    Re: [PATCH 1/3] clocksource/drivers/timer-atmel-pit: Enable mck clock Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-08-30 12:20 +0200

csiph-web