Re: [PATCH v2 5/5] hwrng: amd: Rework of the amd768-hwrng driver

From	Jason Cooper <jason@lakedaemon.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 5/5] hwrng: amd: Rework of the amd768-hwrng driver
Date	2016-08-26 15:40 +0200
Message-ID	<sapwu-7EL-25@gated-at.bofh.it> (permalink)
References	<sa1Nv-PS-13@gated-at.bofh.it> <sa1Nw-PS-27@gated-at.bofh.it> <sa4il-2hA-5@gated-at.bofh.it> <sakQ9-4Cl-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Corentin,

On Fri, Aug 26, 2016 at 10:38:02AM +0200, LABBE Corentin wrote:
> On Thu, Aug 25, 2016 at 02:56:38PM +0000, Jason Cooper wrote:
> > On Thu, Aug 25, 2016 at 02:16:35PM +0200, LABBE Corentin wrote:
> > > This patch convert the hwrng interface used by amd768-rng to its new API
> > > by replacing data_read()/data_present() by read().
> > > 
> > > Furthermore, Instead of having two global variable, it's better to use a
> > > private struct. This will permit to remove amd_pdev variable.
> > > 
> > > Finally, Instead of accessing hw directly via pmbase, it's better to
> > > access after ioport_map() via ioread32/iowrite32.
> > 
> > I was going to recommend a better $subject line, but now I see why it's
> > vague. :(  I would recommend breaking this patch up into three:
> > 
> >   hwrng: amd - Access hardware via ioread32/iowrite32
> >   hwrng: amd - Replace global variable with private struct
> >   hwrng: amd - Convert to new hwrng read() API
> > 
> 
> That was my first idea, but believed that it wasnt worth it.

When working with crypto/rng code, I'm a firm believer in moving
cautiously and deliberately. :-)

> Anyway I will do it.

Thanks!

thx,

Jason.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/5] hwrng: amd: rework of the amd hwrng driver LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-08-25 14:20 +0200
  [PATCH v2 3/5] hwrng: amd: Be consitent with the driver name LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-08-25 14:20 +0200
  [PATCH v2 1/5] hwrng: amd: Fix style problem with blank line LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-08-25 14:20 +0200
  [PATCH v2 2/5] hwrng: amd: use the BIT macro LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-08-25 14:20 +0200
  [PATCH v2 4/5] hwrng: amd: Remove asm/io.h LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-08-25 14:20 +0200
  [PATCH v2 5/5] hwrng: amd: Rework of the amd768-hwrng driver LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-08-25 14:20 +0200
    Re: [PATCH v2 5/5] hwrng: amd: Rework of the amd768-hwrng driver Jason Cooper <jason@lakedaemon.net> - 2016-08-25 17:00 +0200
      Re: [PATCH v2 5/5] hwrng: amd: Rework of the amd768-hwrng driver LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-08-26 10:40 +0200
        Re: [PATCH v2 5/5] hwrng: amd: Rework of the amd768-hwrng driver Jason Cooper <jason@lakedaemon.net> - 2016-08-26 15:40 +0200

csiph-web