Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1470691

Re: [PATCH v2] livepatch/module: make TAINT_LIVEPATCH module-specific

Show all headers | View raw

On Thu, 25 Aug 2016, Josh Poimboeuf wrote:

> There's no reliable way to determine which module tainted the kernel
> with TAINT_LIVEPATCH.  For example, /sys/module/<klp module>/taint
> doesn't report it.  Neither does the "mod -t" command in the crash tool.
> 
> Make it crystal clear who the guilty party is by associating
> TAINT_LIVEPATCH with any module which sets the "livepatch" modinfo
> attribute.  The flag will still get set in the kernel like before, but
> now it also sets the same flag in mod->taint.
> 
> Note that now the taint flag gets set when the module is loaded rather
> than when it's enabled.
> 
> I also renamed find_livepatch_modinfo() to check_modinfo_livepatch() to
> better reflect its purpose: it's basically a livepatch-specific
> sub-function of check_modinfo().
> 
> Reported-by: Chunyu Hu <chuhu@redhat.com>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>

I've preserved the acks from v1 (*) and applied. Thanks.

(*) Rusty's and Jessica's. If either if you disagrees with that, please 
    let me know

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] livepatch/module: make TAINT_LIVEPATCH module-specific Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-25 17:10 +0200
  Re: [PATCH v2] livepatch/module: make TAINT_LIVEPATCH module-specific Petr Mladek <pmladek@suse.com> - 2016-08-25 17:20 +0200
  Re: [PATCH v2] livepatch/module: make TAINT_LIVEPATCH  module-specific Miroslav Benes <mbenes@suse.cz> - 2016-08-26 11:10 +0200
  Re: [PATCH v2] livepatch/module: make TAINT_LIVEPATCH  module-specific Jiri Kosina <jikos@kernel.org> - 2016-08-26 15:00 +0200

csiph-web