Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1470638

Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes
Date 2016-08-26 12:00 +0200
Message-ID <sam5A-5hi-1@gated-at.bofh.it> (permalink)
References <sa48G-2d0-9@gated-at.bofh.it> <sabtv-768-7@gated-at.bofh.it> <salVU-5e5-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Friday, August 26, 2016 11:41:21 AM CEST Arnd Bergmann wrote:
> 
> I think this breaks machines that declare a device that just lists
> SMC91X_USE_32BIT but not SMC91X_USE_16BIT. Right now, the way this
> is interpreted is to use 32-bit accessors for most things, but
> not avoiding 16-bit reads.

I guess my patch has the same problem here, with the

	if (SMC_CAN_USE_8BIT && !SMC_16BIT(lp))

check that is true when a platform device is declared with 32-bit
I/O only but all three are enabled at compile-time. The best check
I can think of here (aside from redefining how the flags work)
would be

#define SMC_8BIT_ONLY(p) 	\
	(((p)->cfg.flags & (SMC91X_USE_8BIT |SMC91X_USE_16BIT | SMC91X_USE_32BIT)) == \
	 SMC91X_USE_8BIT)


	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] smc91x: remove ARM hack for unaligned 16-bit writes Arnd Bergmann <arnd@arndb.de> - 2016-08-25 16:50 +0200
  Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes Arnd Bergmann <arnd@arndb.de> - 2016-08-25 17:00 +0200
    Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes Robert Jarzmik <robert.jarzmik@free.fr> - 2016-08-25 20:10 +0200
      Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-08-26 00:40 +0200
        Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes Arnd Bergmann <arnd@arndb.de> - 2016-08-26 11:50 +0200
          Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes Arnd Bergmann <arnd@arndb.de> - 2016-08-26 12:00 +0200
          Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-08-26 13:40 +0200
            Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-08-26 14:40 +0200
        Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-08-27 17:40 +0200
        Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes Robert Jarzmik <robert.jarzmik@free.fr> - 2016-08-27 17:40 +0200

csiph-web