Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1470606

Re: [PATCH 3/3] ARM: imx: add SMP support for i.MX7D

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject Re: [PATCH 3/3] ARM: imx: add SMP support for i.MX7D
Date 2016-08-26 11:10 +0200
Message-ID <saljb-51o-15@gated-at.bofh.it> (permalink)
References <saljb-51o-17@gated-at.bofh.it> <saljb-51o-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Friday, August 26, 2016 7:12:51 PM CEST Anson Huang wrote:
> i.MX7D has 2 cortex-a7 ARM core, add support for
> booting up SMP kernel with 2 CPUs.
> 
> The existing i.MX SMP code is designed for i.MX6
> series SoCs which have cortex-a9 ARM core, but i.MX7D
> has 2 cortex-a7 ARM core, so we need to add runtime
> check for those differences between cortex-a9 and
> cortex-a7.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> 

Can't you just point i.MX7D to start from secondary_startup
rather than v7_secondary_startup?

 ENTRY(v7_secondary_startup)
+       .word   0xc070                  @ 0xc07 is cortex-a7 id
+       .word   0xfff0                  @ mask for core type
+

This looks like you are trying to execute instructions that are
actually data. Does this work?

On a side note, could you rename v7_secondary_startup to
imx6_secondary_startup? The name sounds overly generic
on a multiplatform kernel.

	Arnd

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH 3/3] ARM: imx: add SMP support for i.MX7D Arnd Bergmann <arnd@arndb.de> - 2016-08-26 11:10 +0200
  RE: [PATCH 3/3] ARM: imx: add SMP support for i.MX7D Yongcai Huang <anson.huang@nxp.com> - 2016-08-26 12:50 +0200

csiph-web