Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1470630
| From | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] arm64: dts: rockchip: fix the address map for WDT0 and WDT1 |
| Date | 2016-08-26 11:50 +0200 |
| Message-ID | <salVT-5e5-3@gated-at.bofh.it> (permalink) |
| References | <saiY1-3qe-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 2016/8/26 14:22, Xing Zheng wrote:
> Dues to incorrect description in the TRM, the WDTs base address
> should be fixed and swap them like this:
> WDT0 - 0xff848000
> WDT1 - 0xff840000
>
> And, it is right that only WDT0 can generate global software reset.
> We will update the TRM to fix it.
>
> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
> ---
>
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index bc86e8c..f0f52c1 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1002,9 +1002,9 @@
> };
> };
>
> - watchdog@ff840000 {
> + watchdog@ff848000 {
Just a nit, should we mark this explicitly as "watchdog0" ?
I still need to look up for which wdt you are using.:)
> compatible = "snps,dw-wdt";
> - reg = <0x0 0xff840000 0x0 0x100>;
> + reg = <0x0 0xff848000 0x0 0x100>;
> clocks = <&cru PCLK_WDT>;
> interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
> };
>
--
Best Regards
Shawn Lin
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] arm64: dts: rockchip: fix the address map for WDT0 and WDT1 Xing Zheng <zhengxing@rock-chips.com> - 2016-08-26 08:40 +0200
Re: [PATCH] arm64: dts: rockchip: fix the address map for WDT0 and WDT1 Shawn Lin <shawn.lin@rock-chips.com> - 2016-08-26 11:50 +0200
Re: [PATCH] arm64: dts: rockchip: fix the address map for WDT0 and WDT1 Xing Zheng <zhengxing@rock-chips.com> - 2016-08-26 12:50 +0200
csiph-web