Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1470437

[RFT PATCH v3 0/3] usb: dwc2: Fix core reset and force mode delays

Path csiph.com!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From John Youn <johnyoun@synopsys.com>
Newsgroups linux.kernel
Subject [RFT PATCH v3 0/3] usb: dwc2: Fix core reset and force mode delays
Date Thu, 25 Aug 2016 23:30:02 +0200
Message-ID <saanL-6sR-3@gated-at.bofh.it> (permalink)
X-Original-To linux-usb@vger.kernel.org
Dkim-Signature v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:cc:cc:cc:cc:cc:cc:cc:cc:cc:cc:cc:cc :cc:date:from:message-id:subject:to:x-sasl-enc:x-sasl-enc; s= smtpout; bh=TDJ6bDPrD3fHNYVjJ/uCji+eJvk=; b=oAJ1xHOJwOEqHU2v5tfm Ho+0wsjD+0noXMJfeuSQraikp5AYN8orcBKzWCi5KyeShwoTDqGwMKQrKtKyBk30 JlGwFaupQINi1TpJRCayYy1KHQ4J1xXUOKjyhITRyMgLpbf+qhAbbLRQDQfIWfEh ESZnNHDcLVgPBWmJY95SeMc=
X-Sasl-Enc GvIXD+Melz6mWeAQS+tHQ4oBMSnyc+1CBhfJOfazlXaa 1472160395
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 44
Organization linux.* mail to news gateway
X-Original-Cc johnyoun@synopsys.com
X-Original-Cc Stefan Wahren <stefan.wahren@i2se.com>
X-Original-Cc Michael Niewoehner <linux@mniewoehner.de>
X-Original-Cc Felipe Balbi <balbi@kernel.org>
X-Original-Cc Tao Huang <huangtao@rock-chips.com>
X-Original-Cc Julius Werner <jwerner@chromium.org>
X-Original-Cc linux-kernel@vger.kernel.org
X-Original-Cc Caesar Wang <caesar.upstream@gmail.com>
X-Original-Cc Heiko Stuebner <heiko@sntech.de>
X-Original-Cc Remi Pommarel <repk@triplefau.lt>
X-Original-Cc Kever Yang <kever.yang@rock-chips.com>
X-Original-Cc Doug Anderson <dianders@chromium.org>
X-Original-Cc Stephen Warren <swarren@wwwdotorg.org>
X-Original-Cc linux-rpi-kernel@lists.infradead.org
X-Original-Cc linux-arm-kernel@lists.infradead.org
X-Original-Date Thu, 25 Aug 2016 14:26:33 -0700
X-Original-Message-ID <cover.1472160194.git.johnyoun@synopsys.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1470437

Show key headers only | View raw


This series tries to account for a delay from the IDDIG debounce
filter when switching modes. This delay is a function of the PHY clock
speed and can range from 5-50 ms. This delay must be taken into
account on core reset and force modes. A full explanation is provided
in the patch commit log and code comments.

Patch 1 is a prerequisite to this fix.

Patch 2 implements the delay for core reset.

Patch 3 implements the delay for set/clear force modes.

Appreciate any testing, especially on RK3188 and RPi platforms.

Patch 1-2 can probably be merged right now as they shouldn't break
anything.

Patch 3 should solve RPi issues, but has problems in RK3188 that need
to be debugged.

v3:
* Added tested-bys for patch 1-2
* Fixed an issue where a function was not returning a value
* Dropped patch 4

v2:
* Broke up the last patch of the original series

Regards,
John

John Youn (3):
  usb: dwc2: gadget: Only initialize device if in device mode
  usb: dwc2: Add delay to core soft reset
  usb: dwc2: Properly account for the force mode delays

 drivers/usb/dwc2/core.c   | 128 ++++++++++++++++++++++++++++++++++++++++------
 drivers/usb/dwc2/core.h   |   1 +
 drivers/usb/dwc2/gadget.c |   7 ++-
 drivers/usb/dwc2/hw.h     |   1 +
 4 files changed, 118 insertions(+), 19 deletions(-)

-- 
2.9.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[RFT PATCH v3 0/3] usb: dwc2: Fix core reset and force mode delays John Youn <johnyoun@synopsys.com> - 2016-08-25 23:30 +0200
  [RFT PATCH v3 3/3] usb: dwc2: Properly account for the force mode delays John Youn <johnyoun@synopsys.com> - 2016-08-25 23:30 +0200

csiph-web