Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1471154

Re: [PATCH] omapdrm: dss: drop unneeded of_node_put() on ref passed to of_get_next_parent()

Show all headers | View raw

To clarify, this patch effectively reverts

commit 2ab9f5879162499e1c4e48613287e3f59e593c4f
gpu: drm: omapdrm: dss-of: add missing of_node_put after calling
of_parse_phandle

except it leaves behind unnecessary verbiage that this commit
introduced. And to be clear, that commit *should* indeed be reverted,
although preferably in its entirety obviously.

of_get_next_parent already drops a ref on its argument, so of_node_put
was never "missing" here.

Matthijs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] omapdrm: dss: drop unneeded of_node_put() on ref passed to of_get_next_parent() Andrey Utkin <andrey_utkin@fastmail.com> - 2016-08-26 14:30 +0200
  Re: [PATCH] omapdrm: dss: drop unneeded of_node_put() on ref passed  to of_get_next_parent() Matthijs van Duin <matthijsvanduin@gmail.com> - 2016-08-27 14:00 +0200
    Re: [PATCH] omapdrm: dss: drop unneeded of_node_put() on ref passed  to of_get_next_parent() Matthijs van Duin <matthijsvanduin@gmail.com> - 2016-08-27 14:10 +0200
      RE: [PATCH] omapdrm: dss: drop unneeded of_node_put() on ref passed  to of_get_next_parent() Peter Chen <peter.chen@nxp.com> - 2016-08-29 05:30 +0200

csiph-web